miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix(core): do not use revokable proxy (#29878)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

`preTaskExecution` hooks used a revocable proxy to monitor updates to
`process.env` then revoking them. Apparently, this also prevents them
from being accessed afterwards which is definitely not intentional.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

`preTaskExecution` hooks use a normal (non-revocable) proxy and restores
`process.env.` to the un-proxied version.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jason Jean 2025-02-05 12:52:54 -05:00 committed by GitHub
parent 35486caa87
commit 09be513439
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
packages/nx/src/project-graph/plugins/loaded-nx-plugin.ts
View File

@ -121,26 +121,19 @@ export class LoadedNxPlugin {
if (plugin.preTasksExecution) {
this.preTasksExecution = async (context: PreTasksExecutionContext) => {
const updates = {};
let revokeFn: () => void;
let originalEnv = process.env;
if (isIsolationEnabled() || isDaemonEnabled()) {
const { proxy, revoke } = Proxy.revocable<NodeJS.ProcessEnv>(
process.env,
{
set: (target, key: string, value) => {
target[key] = value;
updates[key] = value;
return true;
},
}
);
process.env = proxy;
revokeFn = revoke;
process.env = new Proxy<NodeJS.ProcessEnv>(originalEnv, {
set: (target, key: string, value) => {
target[key] = value;
updates[key] = value;
return true;
},
});
}
await plugin.preTasksExecution(this.options, context);
process.env = originalEnv;
if (revokeFn) {
revokeFn();
}
return updates;
};
}