miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): do not warn about custom tasks runners when explicitly usi… (#29669)

Browse Source 
…ng default<!-- Please make sure you have read the submission guidelines
before posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Craigory Coppola 2025-01-21 14:00:28 -05:00 committed by GitHub
parent ee135b20a9
commit 104f06ccb7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nx.json
View File

@ -245,7 +245,7 @@
"nxCloudId": "62d013ea0852fe0a2df74438", "nxCloudId": "62d013ea0852fe0a2df74438",
"nxCloudUrl": "https://staging.nx.app", "nxCloudUrl": "https://staging.nx.app",
"parallel": 1, "parallel": 1,
"bust": 1, "bust": 2,
"defaultBase": "master", "defaultBase": "master",
"conformance": { "conformance": {
"rules": [ "rules": [

10
packages/nx/src/tasks-runner/run-command.ts
View File

@ -912,8 +912,12 @@ export function getRunnerOptions(
return result; return result;
} }
function isCustomRunnerPath(modulePath: string) { function isCustomRunnerPath(modulePath: string) {
return !['nx-cloud', '@nrwl/nx-cloud', defaultTasksRunnerPath].includes( return ![
modulePath 'nx-cloud',
); '@nrwl/nx-cloud',
'nx/tasks-runners/default',
defaultTasksRunnerPath,
].includes(modulePath);
} }