miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix(nextjs): add "@nrwl/workspace" to the generated package.json file for built next apps (#4348)

Browse Source
This commit is contained in:
Jack Hsu 2020-12-18 16:17:04 -05:00 committed by GitHub
parent cd9b96c98e
commit 110fe37c00
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/next/package.json
View File

@ -30,7 +30,7 @@
}, },
"peerDependencies": { "peerDependencies": {
"@nrwl/workspace": "*", "@nrwl/workspace": "*",
"next": "^9.3.3" "next": "^10.0.3"
}, },
"dependencies": { "dependencies": {
"@nrwl/react": "*", "@nrwl/react": "*",

8
packages/next/src/builders/build/lib/create-package-json.ts
View File

@ -15,8 +15,12 @@ function getProjectDeps(context: BuilderContext, rootPackageJson: any) {
const depNames = deps const depNames = deps
.map((d) => d.node) .map((d) => d.node)
.filter((node) => node.type === 'npm') .filter((node) => node.type === 'npm')
.map((node) => node.data.packageName); .map((node) => node.data.packageName)
const dependencies = depNames // Need to make sure @nrwl/workspace is installed
// It is only a peer dependency of @nrwl/next so does not get installed automatically
// See: https://github.com/nrwl/nx/issues/4336
.concat('@nrwl/workspace');
const dependencies: string[] = depNames
.filter((packageName) => packageName in rootPackageJson.dependencies) .filter((packageName) => packageName in rootPackageJson.dependencies)
.reduce((deps, pkgName) => { .reduce((deps, pkgName) => {
return { ...deps, [pkgName]: rootPackageJson.dependencies[pkgName] }; return { ...deps, [pkgName]: rootPackageJson.dependencies[pkgName] };