From 200b62ad4b19e40c39fbeee6ee1d87c93645fac5 Mon Sep 17 00:00:00 2001
From: Sam Tsai <samtsai@gmail.com>
Date: Wed, 16 Oct 2024 05:33:40 -0400
Subject: [PATCH] fix(rspack): replace DefinePlugin with EnvironmentPlugin
 (#28252)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
```
[webpack-dev-server] WARNING
  ⚠ DefinePlugin:
  │ Conflicting values for 'process.env.NODE_ENV' ("'development'" !== "\"development\"")
```

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
`process.env.NODE_ENV` should resolve to `'development'` and not a
quoted value: `"'development'"`

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #28040 (NODE_ENV part)
---
 packages/rspack/src/utils/with-web.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/rspack/src/utils/with-web.ts b/packages/rspack/src/utils/with-web.ts
index 1d735a4d52..1a2e014aa1 100644
--- a/packages/rspack/src/utils/with-web.ts
+++ b/packages/rspack/src/utils/with-web.ts
@@ -117,8 +117,8 @@ export function withWeb(opts: WithWebOptions = {}) {
             ? path.join(context.root, options.indexHtml)
             : path.join(projectRoot, 'src/index.html'),
         }),
-        new rspack.DefinePlugin({
-          'process.env.NODE_ENV': isProd ? "'production'" : "'development'",
+        new rspack.EnvironmentPlugin({
+          NODE_ENV: 'development',
         }),
       ],
     };