From 23d94a82d06850d9076fac254a2d3ba6eba58875 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Leosvel=20P=C3=A9rez=20Espinosa?=
 <leosvel.perez.espinosa@gmail.com>
Date: Tue, 5 Jul 2022 14:21:19 +0100
Subject: [PATCH] fix(misc): handle external nodes correctly in module
 federation additional shared config (#11018)

---
 packages/angular/src/utils/mf/with-module-federation.ts        | 2 +-
 packages/react/src/module-federation/with-module-federation.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/angular/src/utils/mf/with-module-federation.ts b/packages/angular/src/utils/mf/with-module-federation.ts
index c2a8d4091a..09f67ab353 100644
--- a/packages/angular/src/utils/mf/with-module-federation.ts
+++ b/packages/angular/src/utils/mf/with-module-federation.ts
@@ -180,7 +180,7 @@ function addStringDependencyToSharedConfig(
 ): void {
   if (projectGraph.nodes[dependency]) {
     sharedConfig[dependency] = { requiredVersion: false };
-  } else if (projectGraph.externalNodes?.[dependency]) {
+  } else if (projectGraph.externalNodes?.[`npm:${dependency}`]) {
     const pkgJson = readRootPackageJson();
     const config = getNpmPackageSharedConfig(
       dependency,
diff --git a/packages/react/src/module-federation/with-module-federation.ts b/packages/react/src/module-federation/with-module-federation.ts
index 37e15eb0ef..43fdd3594a 100644
--- a/packages/react/src/module-federation/with-module-federation.ts
+++ b/packages/react/src/module-federation/with-module-federation.ts
@@ -170,7 +170,7 @@ function addStringDependencyToSharedConfig(
 ): void {
   if (projectGraph.nodes[dependency]) {
     sharedConfig[dependency] = { requiredVersion: false };
-  } else if (projectGraph.externalNodes?.[dependency]) {
+  } else if (projectGraph.externalNodes?.[`npm:${dependency}`]) {
     const pkgJson = readRootPackageJson();
     const config = getNpmPackageSharedConfig(
       dependency,