From 36cd6b0485325db0f6147320b04e3ffcd41373f4 Mon Sep 17 00:00:00 2001 From: Jack Hsu Date: Tue, 18 Jul 2023 14:27:14 -0400 Subject: [PATCH] fix(core): generate npm preset correctly (#18164) --- .../src/create-nx-workspace-npm.test.ts | 11 +++++++++++ .../create-nx-workspace/bin/create-nx-workspace.ts | 1 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/e2e/workspace-create-npm/src/create-nx-workspace-npm.test.ts b/e2e/workspace-create-npm/src/create-nx-workspace-npm.test.ts index f54ece8d56..2a11dc1031 100644 --- a/e2e/workspace-create-npm/src/create-nx-workspace-npm.test.ts +++ b/e2e/workspace-create-npm/src/create-nx-workspace-npm.test.ts @@ -37,6 +37,17 @@ describe('create-nx-workspace --preset=npm', () => { cleanupProject({ skipReset: true }); }); + it('should setup package-based workspace', () => { + const packageJson = readJson('package.json'); + expect(packageJson.dependencies).toEqual({}); + + if (getSelectedPackageManager() === 'pnpm') { + checkFilesExist('pnpm-workspace.yaml'); + } else { + expect(packageJson.workspaces).toEqual(['packages/*']); + } + }); + it('should add angular application', () => { packageInstall('@nx/angular', wsName); const appName = uniq('my-app'); diff --git a/packages/create-nx-workspace/bin/create-nx-workspace.ts b/packages/create-nx-workspace/bin/create-nx-workspace.ts index 36bce6debd..5b3143c509 100644 --- a/packages/create-nx-workspace/bin/create-nx-workspace.ts +++ b/packages/create-nx-workspace/bin/create-nx-workspace.ts @@ -412,7 +412,6 @@ async function determineNoneOptions( } else { preset = Preset.NPM; } - preset = workspaceType === 'standalone' ? Preset.TsStandalone : Preset.TS; } if (parsedArgs.js !== undefined) {