miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

chore(repo): allow e2e workflows to publish relative versions (#26609)

Browse Source
This commit is contained in:
James Henry 2024-06-21 00:11:35 +04:00 committed by GitHub
parent 7699b33ea1
commit 472459d9f5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
scripts/nx-release.ts
View File

@ -199,6 +199,9 @@ const VALID_AUTHORS_FOR_LATEST = [
})(); })();
function parseArgs() { function parseArgs() {
const registry = getRegistry();
const registryIsLocalhost = registry.hostname === 'localhost';
const parsedArgs = yargs const parsedArgs = yargs
.scriptName('pnpm nx-release') .scriptName('pnpm nx-release')
.wrap(144) .wrap(144)
@ -241,10 +244,14 @@ function parseArgs() {
default: 'minor', default: 'minor',
coerce: (version: string) => { coerce: (version: string) => {
const isGithubActions = !!process.env.GITHUB_ACTIONS; const isGithubActions = !!process.env.GITHUB_ACTIONS;
if (isGithubActions && isRelativeVersionKeyword(version)) { if (
isGithubActions &&
!registryIsLocalhost &&
isRelativeVersionKeyword(version)
) {
// Print error rather than throw to avoid yargs noise in this specifically handled case // Print error rather than throw to avoid yargs noise in this specifically handled case
console.error( console.error(
'Error: The release script was triggered in a GitHub Actions workflow, but a relative version keyword was provided. This is an unexpected combination.' 'Error: The release script was triggered in a GitHub Actions workflow, to a non-local registry, but a relative version keyword was provided. This is an unexpected combination.'
); );
process.exit(1); process.exit(1);
} }
@ -335,8 +342,6 @@ function parseArgs() {
) )
.demandOption('version') .demandOption('version')
.check((args) => { .check((args) => {
const registry = getRegistry();
const registryIsLocalhost = registry.hostname === 'localhost';
if (!args.local) { if (!args.local) {
if (!process.env.GH_TOKEN) { if (!process.env.GH_TOKEN) {
throw new Error('process.env.GH_TOKEN is not set'); throw new Error('process.env.GH_TOKEN is not set');