From 48c6024fd5ac5c1c86adafe23f2972cbf1d14517 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A9rill=20T=C3=A9terel?= <59962715+mteterel@users.noreply.github.com> Date: Fri, 28 Oct 2022 17:23:48 +0200 Subject: [PATCH] fix(cra-to-nx): use cross-env to ensure Windows compatibility with CRA build script (#12838) --- packages/cra-to-nx/src/lib/add-cra-commands-to-nx.ts | 2 +- packages/cra-to-nx/src/lib/cra-to-nx.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/cra-to-nx/src/lib/add-cra-commands-to-nx.ts b/packages/cra-to-nx/src/lib/add-cra-commands-to-nx.ts index c8a63a5304..7a5362df45 100644 --- a/packages/cra-to-nx/src/lib/add-cra-commands-to-nx.ts +++ b/packages/cra-to-nx/src/lib/add-cra-commands-to-nx.ts @@ -6,7 +6,7 @@ export function addCRAcracoScriptsToPackageJson(appName: string) { ...packageJson.scripts, start: 'craco start', serve: 'npm start', - build: `BUILD_PATH=../../dist/apps/${appName} craco build`, + build: `cross-env BUILD_PATH=../../dist/apps/${appName} craco build`, test: 'craco test', }; writeJsonSync(`apps/${appName}/package.json`, packageJson, { spaces: 2 }); diff --git a/packages/cra-to-nx/src/lib/cra-to-nx.ts b/packages/cra-to-nx/src/lib/cra-to-nx.ts index 518339b56c..b2a808b76d 100644 --- a/packages/cra-to-nx/src/lib/cra-to-nx.ts +++ b/packages/cra-to-nx/src/lib/cra-to-nx.ts @@ -165,6 +165,7 @@ export async function createNxWorkspaceForReact(options: Record) { addDependency('@craco/craco', true); addDependency('web-vitals', true); addDependency('jest-watch-typeahead', true); // Only for ts apps? + addDependency('cross-env', true); output.log({ title: '🎉 Done!',