From 56481d6976d8bcabe56c6ecd35e427351d67328c Mon Sep 17 00:00:00 2001 From: Jack Hsu Date: Mon, 18 Sep 2023 11:53:32 -0400 Subject: [PATCH] fix(webpack): set `module: true` for swcMinify (#19213) --- e2e/web/src/web.test.ts | 3 +-- packages/webpack/src/utils/with-nx.ts | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/e2e/web/src/web.test.ts b/e2e/web/src/web.test.ts index ff99ec6582..f0ccc33030 100644 --- a/e2e/web/src/web.test.ts +++ b/e2e/web/src/web.test.ts @@ -25,8 +25,7 @@ describe('Web Components Applications', () => { beforeEach(() => newProject()); afterEach(() => cleanupProject()); - // TODO Re-enable this when it is passing. - xit('should be able to generate a web app', async () => { + it('should be able to generate a web app', async () => { const appName = uniq('app'); runCLI( `generate @nx/web:app ${appName} --bundler=webpack --no-interactive` diff --git a/packages/webpack/src/utils/with-nx.ts b/packages/webpack/src/utils/with-nx.ts index 7261e10d1e..3c140326eb 100644 --- a/packages/webpack/src/utils/with-nx.ts +++ b/packages/webpack/src/utils/with-nx.ts @@ -271,6 +271,7 @@ export function withNx(pluginOptions?: WithNxOptions): NxWebpackPlugin { minify: TerserPlugin.swcMinify, // `terserOptions` options will be passed to `swc` terserOptions: { + module: true, mangle: false, }, }),