miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(linter): ensure too many warnings is only logged if enabled (#27083)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

ESLint found too many warnings (maximum: -1).

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Nothing should be logged if maximum is set to -1
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Denis Frenademetz 2024-07-25 10:10:07 +02:00 committed by GitHub
parent 3890edc560
commit 5d5b13e783
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/eslint/src/executors/lint/lint.impl.ts
View File

@ -200,7 +200,7 @@ Please see https://nx.dev/recipes/tips-n-tricks/eslint for full guidance on how
outputPrintInfo(totals);
}
if (totals.warnings > options.maxWarnings) {
if (options.maxWarnings >= 0 && totals.warnings > options.maxWarnings) {
console.info(
`ESLint found too many warnings (maximum: ${options.maxWarnings}).`
);