miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

chore(core): cleanup some code in find-matching-projects (#16523)

Browse Source
This commit is contained in:
Craigory Coppola 2023-04-24 18:37:22 -04:00 committed by GitHub
parent eb477479bf
commit 5d8839a7dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/nx/src/utils/find-matching-projects.ts
View File

@ -90,7 +90,10 @@ export function findMatchingProjects(
// Same thing as `type:unlabeled`. If no specific type is set, // Same thing as `type:unlabeled`. If no specific type is set,
// we can waterfall through the different types until we find a match // we can waterfall through the different types until we find a match
default: { default: {
const size = selectedProjects.size + excludedProjects.size; // The size of the selected and excluded projects set, before we
// start updating it with this pattern. If the size changes, we
// know we found a match and can skip the other types.
const originalSize = selectedProjects.size + excludedProjects.size;
addMatchingProjectsByName( addMatchingProjectsByName(
projectNames, projectNames,
projects, projects,
@ -98,7 +101,7 @@ export function findMatchingProjects(
excludedProjects, excludedProjects,
selectedProjects selectedProjects
); );
if (selectedProjects.size + excludedProjects.size > size) { if (selectedProjects.size + excludedProjects.size > originalSize) {
// There was some match by name, don't check other types // There was some match by name, don't check other types
continue; continue;
} }
@ -109,7 +112,7 @@ export function findMatchingProjects(
excludedProjects, excludedProjects,
selectedProjects selectedProjects
); );
if (selectedProjects.size + excludedProjects.size > size) { if (selectedProjects.size + excludedProjects.size > originalSize) {
// There was some match by directory, don't check other types // There was some match by directory, don't check other types
// Note - this doesn't do anything currently, but preps for future // Note - this doesn't do anything currently, but preps for future
// types // types