miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

docs(misc): fix scrolling on reference page (#11940)

Browse Source
This commit is contained in:
Jack Hsu 2022-09-08 21:10:59 -04:00 committed by GitHub
parent 31b1b003b4
commit 629dbe9f79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
nx-dev/nx-dev/pages/packages.tsx
View File

@ -25,20 +25,35 @@ const nxPackageIds = ['nx', 'workspace', 'devkit', 'nx-plugin'];
export default function Packages(props: ReferencesProps): JSX.Element {
const router = useRouter();
const [pathname, hash] = router.asPath.split('#');
const updateTargetPackageId = useCallback(
(id: string) => router.push(`${pathname}#${id}`),
[pathname, router]
);
const [pathname, hash = ''] = router.asPath.split('#');
const validIds = useMemo(
() => props.references.itemList.map((item) => item.id),
[props.references]
);
const fromHash = validIds.some((id) => hash === id) ? hash : '';
const idFromHash = validIds.some((id) => hash === id) ? hash : '';
const [targetPackageId, setTargetPackageId] = useState<string>('');
// Only run this effect initially to sync the id once, or else we run into a hydration warning.
useEffect(() => {
setTargetPackageId(fromHash);
}, [fromHash]);
setTargetPackageId(idFromHash);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
// Update URL for deep-links
useEffect(() => {
if (hash === targetPackageId) return;
if (targetPackageId) {
router.replace(`${pathname}#${targetPackageId}`);
} else {
router.replace(pathname, undefined, { scroll: false });
}
}, [pathname, router, targetPackageId, hash]);
const updateTargetPackageId = useCallback(
(id: string) =>
id === targetPackageId ? setTargetPackageId('') : setTargetPackageId(id),
[targetPackageId]
);
const references: MenuItem[] = useMemo(
() =>
[