miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(bundling): remove migration always adding sass-embedded (#30276)

Browse Source 
## Current Behavior
There is a migration that always adds `sass-embedded` for Rspack and
Webpack for 20.5

## Expected Behavior
`sass-embedded` is already a dependency of Rspack and Webpack and
therefore does not need to be added to users package.json - especially
as they may not be using it.
This commit is contained in:
Colum Ferry 2025-03-05 19:12:33 +00:00 committed by GitHub
parent 7ba707e7b3
commit 648129fc48
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/generated/packages/rspack/migrations/20.5.0-package-updates.json
View File

@ -2,8 +2,7 @@
"name": "20.5.0-package-updates", "name": "20.5.0-package-updates",
"version": "20.5.0-beta.4", "version": "20.5.0-beta.4",
"packages": { "packages": {
"sass-embedded": { "version": "^1.83.4", "alwaysAddToPackageJson": true }, "sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false },
"sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": true },
"@rspack/core": { "version": "^1.2.2", "alwaysAddToPackageJson": false } "@rspack/core": { "version": "^1.2.2", "alwaysAddToPackageJson": false }
}, },
"aliases": [], "aliases": [],

3
docs/generated/packages/webpack/migrations/20.5.0-package-updates.json
View File

@ -2,8 +2,7 @@
"name": "20.5.0-package-updates", "name": "20.5.0-package-updates",
"version": "20.5.0-beta.3", "version": "20.5.0-beta.3",
"packages": { "packages": {
"sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false }, "sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false }
"sass-embedded": { "version": "^1.83.4", "alwaysAddToPackageJson": true }
}, },
"aliases": [], "aliases": [],
"description": "", "description": "",

6
packages/rspack/migrations.json
View File

@ -98,13 +98,9 @@
"20.5.0": { "20.5.0": {
"version": "20.5.0-beta.4", "version": "20.5.0-beta.4",
"packages": { "packages": {
"sass-embedded": {
"version": "^1.83.4",
"alwaysAddToPackageJson": true
},
"sass-loader": { "sass-loader": {
"version": "^16.0.4", "version": "^16.0.4",
"alwaysAddToPackageJson": true "alwaysAddToPackageJson": false
}, },
"@rspack/core": { "@rspack/core": {
"version": "^1.2.2", "version": "^1.2.2",

4
packages/webpack/migrations.json
View File

@ -42,10 +42,6 @@
"sass-loader": { "sass-loader": {
"version": "^16.0.4", "version": "^16.0.4",
"alwaysAddToPackageJson": false "alwaysAddToPackageJson": false
},
"sass-embedded": {
"version": "^1.83.4",
"alwaysAddToPackageJson": true
} }
} }
} }