miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): run script should exit the process when kill signals are r… (#31109)

Browse Source
This commit is contained in:
Jason Jean 2025-05-07 13:42:27 -04:00 committed by GitHub
parent 3b3b320ff7
commit 68426f6adb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
packages/nx/src/executors/run-script/run-script.impl.ts
View File

@ -4,8 +4,10 @@ import type { ExecutorContext } from '../../config/misc-interfaces';
import {
createPseudoTerminal,
PseudoTerminal,
PseudoTtyProcess,
} from '../../tasks-runner/pseudo-terminal';
import { getPackageManagerCommand } from '../../utils/package-manager';
import { signalToCode } from '../../utils/exit-codes';
export interface RunScriptOptions {
script: string;
@ -58,6 +60,8 @@ function nodeProcess(
});
}
let cp: PseudoTtyProcess | undefined;
async function ptyProcess(
command: string,
cwd: string,
@ -67,7 +71,7 @@ async function ptyProcess(
await terminal.init();
return new Promise<void>((res, rej) => {
const cp = terminal.runCommand(command, { cwd, jsEnv: env });
cp = terminal.runCommand(command, { cwd, jsEnv: env });
cp.onExit((code) => {
if (code === 0) {
res();
@ -79,3 +83,17 @@ async function ptyProcess(
});
});
}
// TODO: This only works because pseudo terminal registers signal handlers first but we need a service to handle this
process.on('SIGHUP', () => {
cp.kill('SIGHUP');
process.exit(signalToCode('SIGHUP'));
});
process.on('SIGTERM', () => {
cp.kill('SIGTERM');
process.exit(signalToCode('SIGTERM'));
});
process.on('SIGINT', () => {
cp.kill('SIGINT');
process.exit(signalToCode('SIGINT'));
});