From 72b0f5560567ba0f7cdcffea754a47ae6753d77a Mon Sep 17 00:00:00 2001 From: Emily Xiong Date: Wed, 31 May 2023 08:37:24 -0400 Subject: [PATCH] feat(js): add location none to verdaccio executor (#17319) --- docs/generated/packages/js/executors/verdaccio.json | 2 +- packages/js/src/executors/verdaccio/schema.d.ts | 2 +- packages/js/src/executors/verdaccio/schema.json | 2 +- packages/js/src/executors/verdaccio/verdaccio.impl.ts | 6 +++++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/generated/packages/js/executors/verdaccio.json b/docs/generated/packages/js/executors/verdaccio.json index 931ce53e72..be85820335 100644 --- a/docs/generated/packages/js/executors/verdaccio.json +++ b/docs/generated/packages/js/executors/verdaccio.json @@ -13,7 +13,7 @@ "type": "string", "description": "Location option for npm config", "default": "user", - "enum": ["global", "user", "project"] + "enum": ["global", "user", "project", "none"] }, "storage": { "type": "string", diff --git a/packages/js/src/executors/verdaccio/schema.d.ts b/packages/js/src/executors/verdaccio/schema.d.ts index 0744a5d8d1..3e25c6f209 100644 --- a/packages/js/src/executors/verdaccio/schema.d.ts +++ b/packages/js/src/executors/verdaccio/schema.d.ts @@ -1,5 +1,5 @@ export interface VerdaccioExecutorSchema { - location?: string; + location: 'global' | 'user' | 'project' | 'none'; storage?: string; port: number; config?: string; diff --git a/packages/js/src/executors/verdaccio/schema.json b/packages/js/src/executors/verdaccio/schema.json index a6b63a650d..0948d7cae6 100644 --- a/packages/js/src/executors/verdaccio/schema.json +++ b/packages/js/src/executors/verdaccio/schema.json @@ -10,7 +10,7 @@ "type": "string", "description": "Location option for npm config", "default": "user", - "enum": ["global", "user", "project"] + "enum": ["global", "user", "project", "none"] }, "storage": { "type": "string", diff --git a/packages/js/src/executors/verdaccio/verdaccio.impl.ts b/packages/js/src/executors/verdaccio/verdaccio.impl.ts index be1a14d4cd..6b6adef99f 100644 --- a/packages/js/src/executors/verdaccio/verdaccio.impl.ts +++ b/packages/js/src/executors/verdaccio/verdaccio.impl.ts @@ -25,7 +25,8 @@ export async function verdaccioExecutor( if (options.clear && options.storage && existsSync(options.storage)) { removeSync(options.storage); } - const cleanupFunctions = [setupNpm(options), setupYarn(options)]; + const cleanupFunctions = + options.location === 'none' ? [] : [setupNpm(options), setupYarn(options)]; const processExitListener = (signal?: number | NodeJS.Signals) => { if (childProcess) { @@ -148,6 +149,9 @@ function setupNpm(options: VerdaccioExecutorSchema) { } else { execSync(`npm config delete registry --location ${options.location}`); } + execSync( + `npm config delete //localhost:${options.port}/:_authToken --location ${options.location}` + ); } catch (e) { throw new Error(`Failed to reset npm registry: ${e.message}`); }