fix(core): handle spaces when launching nxFork (#21571)

Cargo.lock

@@ -1561,6 +1561,7 @@ dependencies = [
  "watchexec-events",
  "watchexec-filterer-ignore",
  "watchexec-signals",
+ "winapi",
  "xxhash-rust",
 ]
 

packages/nx/Cargo.toml

@@ -44,6 +44,9 @@ swc_ecma_visit = "0.93.0"
 swc_ecma_ast = "0.107.0"
 crossterm = "0.27.0"
 
+[target.'cfg(windows)'.dependencies]
+winapi = { version = "0.3", features = ["fileapi"] }
+
 [lib]
 crate-type = ['cdylib']
 

packages/nx/src/native/command.rs

@@ -12,6 +12,7 @@ use napi::threadsafe_function::ThreadsafeFunction;
 use napi::threadsafe_function::ThreadsafeFunctionCallMode::NonBlocking;
 use napi::{Env, JsFunction};
 use portable_pty::{ChildKiller, CommandBuilder, NativePtySystem, PtySize, PtySystem};
+use tracing::trace;
 
 #[cfg(target_os = "windows")]
 static CURSOR_POSITION: std::sync::OnceLock<regex::Regex> = std::sync::OnceLock::new();
@@ -234,10 +235,47 @@ pub fn nx_fork(
     js_env: Option<HashMap<String, String>>,
     quiet: bool,
 ) -> napi::Result<ChildProcess> {
-    run_command(
+    let command = format!(
-        format!("node {} {} {}", fork_script, psuedo_ipc_path, id),
+        "node {} {} {}",
-        command_dir,
+        handle_path_space(fork_script),
-        js_env,
+        psuedo_ipc_path,
-        Some(quiet),
+        id
-    )
+    );
+
+    trace!("nx_fork command: {}", &command);
+    run_command(command, command_dir, js_env, Some(quiet))
+}
+
+#[cfg(target_os = "windows")]
+pub fn handle_path_space(path: String) -> String {
+    use std::os::windows::ffi::OsStrExt;
+    use std::{ffi::OsString, os::windows::ffi::OsStringExt};
+
+    use winapi::um::fileapi::GetShortPathNameW;
+    let wide: Vec<u16> = std::path::PathBuf::from(&path)
+        .as_os_str()
+        .encode_wide()
+        .chain(Some(0))
+        .collect();
+    let mut buffer: Vec<u16> = vec![0; wide.len() * 2];
+    let result =
+        unsafe { GetShortPathNameW(wide.as_ptr(), buffer.as_mut_ptr(), buffer.len() as u32) };
+    if result == 0 {
+        path
+    } else {
+        let len = buffer.iter().position(|&x| x == 0).unwrap();
+        let short_path: String = OsString::from_wide(&buffer[..len])
+            .to_string_lossy()
+            .into_owned();
+        short_path
+    }
+}
+
+#[cfg(not(target_os = "windows"))]
+fn handle_path_space(path: String) -> String {
+    if path.contains(' ') {
+        format!("'{}'", path)
+    } else {
+        path
+    }
 }