From 79ee8573808524c5217c79cae8ffc69d1b0de314 Mon Sep 17 00:00:00 2001 From: Nicholas Cunningham Date: Wed, 8 May 2024 14:18:37 -0600 Subject: [PATCH] docs(nx-dev): Update docs sidemenu enabling the close button (#23254) This PR fixes the issue where the close button was not working in the nx-dev documentation pages after opening the overflow menu. Now, the close button functions correctly. --- nx-dev/nx-dev/pages/[...segments].tsx | 6 +- nx-dev/nx-dev/pages/ai-chat/index.tsx | 6 +- nx-dev/nx-dev/pages/changelog.tsx | 12 +- nx-dev/nx-dev/pages/ci/[...segments].tsx | 6 +- nx-dev/nx-dev/pages/ci/index.tsx | 6 +- .../pages/extending-nx/[...segments].tsx | 6 +- nx-dev/nx-dev/pages/extending-nx/index.tsx | 6 +- .../nx-api/[name]/documents/[...segments].tsx | 6 +- .../pages/nx-api/[name]/documents/index.tsx | 6 +- .../nx-api/[name]/executors/[...segments].tsx | 6 +- .../pages/nx-api/[name]/executors/index.tsx | 6 +- .../[name]/generators/[...segments].tsx | 6 +- .../pages/nx-api/[name]/generators/index.tsx | 6 +- nx-dev/nx-dev/pages/nx-api/[name]/index.tsx | 6 +- nx-dev/nx-dev/pages/nx-api/index.tsx | 6 +- .../pages/nx-api/rspack/documents/index.tsx | 6 +- .../nx-api/rspack/documents/overview.tsx | 6 +- .../rspack/documents/rspack-plugins.tsx | 6 +- .../nx-api/rspack/executors/dev-server.tsx | 6 +- .../pages/nx-api/rspack/executors/index.tsx | 6 +- .../pages/nx-api/rspack/executors/rspack.tsx | 6 +- .../nx-api/rspack/generators/application.tsx | 6 +- .../rspack/generators/configuration.tsx | 6 +- .../pages/nx-api/rspack/generators/index.tsx | 6 +- .../pages/nx-api/rspack/generators/init.tsx | 6 +- nx-dev/nx-dev/pages/nx-api/rspack/index.tsx | 6 +- .../ui-common/src/lib/sidebar-container.tsx | 10 +- nx-dev/ui-common/src/lib/sidebar.tsx | 134 +++++++++++------- 28 files changed, 225 insertions(+), 81 deletions(-) diff --git a/nx-dev/nx-dev/pages/[...segments].tsx b/nx-dev/nx-dev/pages/[...segments].tsx index 71d706fda1..ec5afecbd0 100644 --- a/nx-dev/nx-dev/pages/[...segments].tsx +++ b/nx-dev/nx-dev/pages/[...segments].tsx @@ -57,7 +57,11 @@ export default function NxDocumentation({ role="main" className="flex h-full flex-1 overflow-y-hidden" > - +
- +
diff --git a/nx-dev/nx-dev/pages/changelog.tsx b/nx-dev/nx-dev/pages/changelog.tsx index c5e6d070ea..c69e331f73 100644 --- a/nx-dev/nx-dev/pages/changelog.tsx +++ b/nx-dev/nx-dev/pages/changelog.tsx @@ -223,15 +223,19 @@ export default function Changelog(props: ChangeLogProps): JSX.Element {
-
+
- +
-

+

Nx Changelog

@@ -271,7 +275,7 @@ export default function Changelog(props: ChangeLogProps): JSX.Element { v{changelog.version.split('.').slice(0, 2).join('.')} - +

diff --git a/nx-dev/nx-dev/pages/ci/[...segments].tsx b/nx-dev/nx-dev/pages/ci/[...segments].tsx index baa4da30d2..68c6bf3fb7 100644 --- a/nx-dev/nx-dev/pages/ci/[...segments].tsx +++ b/nx-dev/nx-dev/pages/ci/[...segments].tsx @@ -65,7 +65,11 @@ export default function Pages({ role="main" className="flex h-full flex-1 overflow-y-hidden" > - +

- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
- +
void; }): JSX.Element { // TODO(jack): Remove this rspack modification once we move rspack into main repo (when stable). const menuWithRspack = useMemo(() => { @@ -128,8 +130,12 @@ export function SidebarContainer({ return (