miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(web): undo core-js removal (#17048)

Browse Source
This commit is contained in:
Jack Hsu 2023-05-16 09:19:02 -04:00 committed by GitHub
parent 1e4f4952f6
commit 826befa22d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/web/migrations.json
View File

@ -71,12 +71,6 @@
"version": "16.0.0-beta.4",
"description": "Replace @nrwl/web executors with @nx/webpack and @nx/rollup",
"implementation": "./src/migrations/update-16-0-0-update-executors/update-16-0-0-update-executors"
},
"update-16-2-0-remove-packages": {
"cli": "nx",
"version": "16.2.0-beta.0",
"description": "Remove core-js and regenerator-runtime packages",
"implementation": "./src/migrations/update-16-2-0-remove-packages/update-16-2-0-remove-packages"
}
},
"packageJsonUpdates": {

27
packages/web/src/migrations/update-16-2-0-remove-packages/update-16-2-0-remove-packages.spec.ts
View File

@ -1,27 +0,0 @@
import { Tree, readJson, updateJson } from '@nx/devkit';
import { createTreeWithEmptyWorkspace } from 'nx/src/devkit-testing-exports';
import removePackages from './update-16-2-0-remove-packages';
describe('update-16-2-0-remove-packages', () => {
let tree: Tree;
beforeEach(() => {
tree = createTreeWithEmptyWorkspace();
updateJson(tree, 'package.json', (json) => {
json.dependencies['core-js'] = '3.6.5';
json.dependencies['regenerator-runtime'] = '0.13.7';
return json;
});
});
it('should remove core-js & regenerator-runtime packages', async () => {
await removePackages(tree);
expect(
readJson(tree, 'package.json').dependencies['core-js']
).not.toBeDefined();
expect(
readJson(tree, 'package.json').dependencies['regenerator-runtime']
).not.toBeDefined();
});
});

15
packages/web/src/migrations/update-16-2-0-remove-packages/update-16-2-0-remove-packages.ts
View File

@ -1,15 +0,0 @@
import {
Tree,
formatFiles,
removeDependenciesFromPackageJson,
} from '@nx/devkit';
export default async function removePackages(tree: Tree): Promise<void> {
removeDependenciesFromPackageJson(
tree,
['core-js', 'regenerator-runtime'],
[]
);
await formatFiles(tree);
}