From 8f7d959364ecc4ac7360f87fca88125036166dbc Mon Sep 17 00:00:00 2001 From: Jason Jean Date: Wed, 21 Apr 2021 18:29:44 -0400 Subject: [PATCH] fix(core): override root config target dependencies instead of merge (#5424) --- packages/workspace/src/tasks-runner/utils.ts | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/packages/workspace/src/tasks-runner/utils.ts b/packages/workspace/src/tasks-runner/utils.ts index f7884b5768..34d01f31d8 100644 --- a/packages/workspace/src/tasks-runner/utils.ts +++ b/packages/workspace/src/tasks-runner/utils.ts @@ -81,17 +81,11 @@ export function getDependencyConfigs( defaultDependencyConfigs: Record, projectGraph: ProjectGraph ): TargetDependencyConfig[] | undefined { - const dependencyConfigs = new Set( - defaultDependencyConfigs[target] ?? [] - ); - const projectDependencyConfigs = - projectGraph.nodes[project].data?.targets[target]?.dependsOn; - - if (projectDependencyConfigs) { - for (const dependencyConfig of projectDependencyConfigs) { - dependencyConfigs.add(dependencyConfig); - } - } + // DependencyConfigs configured in workspace.json override configurations at the root. + const dependencyConfigs = + projectGraph.nodes[project].data?.targets[target]?.dependsOn ?? + defaultDependencyConfigs[target] ?? + []; for (const dependencyConfig of dependencyConfigs) { if ( @@ -107,7 +101,7 @@ export function getDependencyConfigs( process.exit(1); } } - return Array.from(dependencyConfigs); + return dependencyConfigs; } export function getOutputs(p: Record, task: Task) {