miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

chore(repo): switch macos e2e test to not use atomizer (#27272)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
MaxKless 2024-08-02 16:18:51 +02:00 committed by GitHub
parent a07aa5e966
commit 97d4184709
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.circleci/config.yml
View File

@ -160,7 +160,7 @@ jobs:
command: |
HAS_CHANGED=$(node ./scripts/check-react-native-changes.js $NX_BASE $NX_HEAD);
if $HAS_CHANGED; then
pnpm nx affected -t e2e-macos-ci --parallel=1 --base=$NX_BASE --head=$NX_HEAD
pnpm nx affected -t e2e-macos-local --parallel=1 --base=$NX_BASE --head=$NX_HEAD
else
echo "Skip E2E tests for macOS as there are no changes in React Native projects."
fi

3
e2e/react-native/src/react-native-legacy.test.ts
View File

@ -191,7 +191,8 @@ describe('@nx/react-native (legacy)', () => {
);
});
it('should upgrade native for application', async () => {
// TODO(@xiongemi): Look into this test failing on macos
xit('should upgrade native for application', async () => {
expect(() => runCLI(`upgrade ${appName}`)).not.toThrow();
});

7
nx.json
View File

@ -133,6 +133,11 @@
"e2e-ci": {
"inputs": ["e2eInputs", "^production"]
},
"e2e-macos-local": {
"cache": true,
"inputs": ["e2eInputs", "^production"],
"parallelism": false
},
"e2e-macos-ci": {
"inputs": ["e2eInputs", "^production"]
},
@ -216,7 +221,7 @@
"plugin": "@nx/jest/plugin",
"include": ["e2e/detox/**/*", "e2e/react-native/**/*", "e2e/expo/**/*"],
"options": {
"targetName": "e2e-local",
"targetName": "e2e-macos-local",
"ciTargetName": "e2e-macos-ci"
}
}