miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

chore(core): fix editor detection tests when running in cursor (#31478)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Running tests in the Cursor terminal fails. 

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Running tests in the Cursor terminal should pass. 

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jonathan Cammisuli 2025-06-06 12:03:43 -04:00 committed by GitHub
parent c5146d1b5f
commit 9c366d39c4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/nx/src/native/tui/nx_console.rs
View File

@ -129,6 +129,10 @@ mod tests {
fn test_vscode_without_askpass_confirmation() {
let mut test_env = HashMap::new();
test_env.insert("TERM_PROGRAM".to_string(), "vscode".to_string());
test_env.insert(
"VSCODE_GIT_ASKPASS_NODE".to_string(),
"some/path/with/vscode/in/it".to_string(),
);
// No VSCODE_GIT_ASKPASS_NODE set or doesn't contain "vscode"
assert_eq!(detect_editor(test_env), SupportedEditor::VSCode);
}