miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(react-native): remove listDevices default value for run-android (#16410)

Browse Source
This commit is contained in:
Emily Xiong 2023-04-19 14:03:45 -04:00 committed by GitHub
parent 1743ff10ed
commit 9c9abaa098
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/generated/packages/react-native/executors/run-android.json
View File

@ -53,8 +53,7 @@
}, },
"listDevices": { "listDevices": {
"type": "boolean", "type": "boolean",
"description": "Lists all available Android devices and simulators and let you choose one to run the app", "description": "Lists all available Android devices and simulators and let you choose one to run the app"
"default": false
}, },
"binaryPath": { "binaryPath": {
"type": "string", "type": "string",
@ -93,7 +92,6 @@
"activeArchOnly": { "activeArchOnly": {
"type": "boolean", "type": "boolean",
"description": "Build native libraries only for the current device architecture for debug builds.", "description": "Build native libraries only for the current device architecture for debug builds.",
"examples": ["x86_64", "arm64-v8a"],
"default": false "default": false
}, },
"extraParams": { "extraParams": {

2
packages/react-native/src/executors/run-android/run-android.impl.ts
View File

@ -105,6 +105,6 @@ function createRunAndroidOptions(options: ReactNativeRunAndroidOptions) {
return getCliOptions<ReactNativeRunAndroidOptions>( return getCliOptions<ReactNativeRunAndroidOptions>(
options, options,
[...nxOptions, ...startOptions, ...deprecatedOptions], [...nxOptions, ...startOptions, ...deprecatedOptions],
['appId', 'appIdSuffix'] ['appId', 'appIdSuffix', 'deviceId']
); );
} }

4
packages/react-native/src/executors/run-android/schema.json
View File

@ -53,8 +53,7 @@
}, },
"listDevices": { "listDevices": {
"type": "boolean", "type": "boolean",
"description": "Lists all available Android devices and simulators and let you choose one to run the app", "description": "Lists all available Android devices and simulators and let you choose one to run the app"
"default": false
}, },
"binaryPath": { "binaryPath": {
"type": "string", "type": "string",
@ -95,7 +94,6 @@
"activeArchOnly": { "activeArchOnly": {
"type": "boolean", "type": "boolean",
"description": "Build native libraries only for the current device architecture for debug builds.", "description": "Build native libraries only for the current device architecture for debug builds.",
"examples": ["x86_64", "arm64-v8a"],
"default": false "default": false
}, },
"extraParams": { "extraParams": {