miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(storybook): revert to previous defaults for Storybook CLI options (#14498)

Browse Source
This commit is contained in:
Katerina Skroumpelou 2023-01-20 00:37:24 +02:00 committed by GitHub
parent 6c926d8c32
commit 9f0a7f07ca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/generated/packages/storybook/executors/build.json
View File

@ -100,13 +100,11 @@
}, },
"quiet": { "quiet": {
"type": "boolean", "type": "boolean",
"description": "Suppress verbose build output.", "description": "Suppress verbose build output."
"default": false
}, },
"docs": { "docs": {
"type": "boolean", "type": "boolean",
"description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation.", "description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation."
"default": false
} }
}, },
"definitions": { "definitions": {

6
docs/generated/packages/storybook/executors/storybook.json
View File

@ -73,13 +73,11 @@
}, },
"quiet": { "quiet": {
"type": "boolean", "type": "boolean",
"description": "Suppress verbose build output.", "description": "Suppress verbose build output."
"default": false
}, },
"docs": { "docs": {
"type": "boolean", "type": "boolean",
"description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation.", "description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation."
"default": false
}, },
"docsMode": { "docsMode": {
"type": "boolean", "type": "boolean",

6
packages/storybook/src/executors/build-storybook/schema.json
View File

@ -77,13 +77,11 @@
}, },
"quiet": { "quiet": {
"type": "boolean", "type": "boolean",
"description": "Suppress verbose build output.", "description": "Suppress verbose build output."
"default": false
}, },
"docs": { "docs": {
"type": "boolean", "type": "boolean",
"description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation.", "description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation."
"default": false
} }
}, },
"definitions": { "definitions": {

6
packages/storybook/src/executors/storybook/schema.json
View File

@ -75,13 +75,11 @@
}, },
"quiet": { "quiet": {
"type": "boolean", "type": "boolean",
"description": "Suppress verbose build output.", "description": "Suppress verbose build output."
"default": false
}, },
"docs": { "docs": {
"type": "boolean", "type": "boolean",
"description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation.", "description": "Starts Storybook in documentation mode. Learn more about it : https://storybook.js.org/docs/react/writing-docs/build-documentation#preview-storybooks-documentation."
"default": false
}, },
"docsMode": { "docsMode": {
"type": "boolean", "type": "boolean",

6
packages/webpack/src/utils/with-nx.ts
View File

@ -164,7 +164,7 @@ export function withNx(opts?: { skipTypeChecking?: boolean }) {
profile: options.statsJson, profile: options.statsJson,
resolve: { resolve: {
...config.resolve, ...config.resolve,
extensions, extensions: [...extensions, ...(config?.resolve?.extensions ?? [])],
alias: options.fileReplacements.reduce( alias: options.fileReplacements.reduce(
(aliases, replacement) => ({ (aliases, replacement) => ({
...aliases, ...aliases,
@ -173,9 +173,10 @@ export function withNx(opts?: { skipTypeChecking?: boolean }) {
{} {}
), ),
plugins: [ plugins: [
...(config.resolve?.plugins ?? []),
new TsconfigPathsPlugin({ new TsconfigPathsPlugin({
configFile: options.tsConfig, configFile: options.tsConfig,
extensions, extensions: [...extensions, ...(config?.resolve?.extensions ?? [])],
mainFields, mainFields,
}), }),
], ],
@ -231,6 +232,7 @@ export function withNx(opts?: { skipTypeChecking?: boolean }) {
// Enabled for performance // Enabled for performance
unsafeCache: true, unsafeCache: true,
rules: [ rules: [
...(config?.module?.rules ?? []),
options.sourceMap && { options.sourceMap && {
test: /\.js$/, test: /\.js$/,
enforce: 'pre' as const, enforce: 'pre' as const,