fix(js): do not generate explicit vitest task config for a js library unless adding plugin is disabled (#29606)
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Generating a js library with any bundler other than `vite` and with the `vitest` test runner results in an explicit `test` task in the project configuration. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Generating a js library with any bundler other than `vite` and with the `vitest` test runner should not generate an explicit `test` task in the project configuration. The `test` task should be inferred. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
This commit is contained in:
parent
dc2c9dae24
commit
a352c81876
@ -172,6 +172,7 @@ export async function libraryGeneratorInternal(
|
|||||||
testEnvironment: options.testEnvironment,
|
testEnvironment: options.testEnvironment,
|
||||||
runtimeTsconfigFileName: 'tsconfig.lib.json',
|
runtimeTsconfigFileName: 'tsconfig.lib.json',
|
||||||
compiler: options.compiler === 'swc' ? 'swc' : 'babel',
|
compiler: options.compiler === 'swc' ? 'swc' : 'babel',
|
||||||
|
addPlugin: options.addPlugin,
|
||||||
});
|
});
|
||||||
tasks.push(vitestTask);
|
tasks.push(vitestTask);
|
||||||
createOrEditViteConfig(
|
createOrEditViteConfig(
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user