miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix(core): generate proper cli command in lib readme

Browse Source
This commit is contained in:
Martin Hochel 2020-08-02 16:00:37 +02:00 committed by Victor Savkin
parent 91f4f60328
commit a3fc7e18c0
3 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/workspace/src/schematics/library/files/lib/README.md
View File

@ -5,6 +5,6 @@ This library was generated with [Nx](https://nx.dev).
## Running unit tests ## Running unit tests
Run `ng test <%= name %>` to execute the unit tests via [Jest](https://jestjs.io). Run `<%= cliCommand %> test <%= name %>` to execute the unit tests via [Jest](https://jestjs.io).
<% } %> <% } %>

6
packages/workspace/src/schematics/library/library.spec.ts
View File

@ -2,6 +2,7 @@ import { Tree } from '@angular-devkit/schematics';
import { createEmptyWorkspace } from '@nrwl/workspace/testing'; import { createEmptyWorkspace } from '@nrwl/workspace/testing';
import { readJsonInTree, updateJsonInTree } from '@nrwl/workspace'; import { readJsonInTree, updateJsonInTree } from '@nrwl/workspace';
import { NxJson } from '@nrwl/workspace'; import { NxJson } from '@nrwl/workspace';
import { runSchematic } from '../../utils/testing'; import { runSchematic } from '../../utils/testing';
describe('lib', () => { describe('lib', () => {
@ -103,9 +104,14 @@ describe('lib', () => {
it('should generate files', async () => { it('should generate files', async () => {
const tree = await runSchematic('lib', { name: 'myLib' }, appTree); const tree = await runSchematic('lib', { name: 'myLib' }, appTree);
expect(tree.exists(`libs/my-lib/jest.config.js`)).toBeTruthy(); expect(tree.exists(`libs/my-lib/jest.config.js`)).toBeTruthy();
expect(tree.exists('libs/my-lib/src/index.ts')).toBeTruthy(); expect(tree.exists('libs/my-lib/src/index.ts')).toBeTruthy();
expect(tree.exists('libs/my-lib/src/lib/my-lib.ts')).toBeTruthy(); expect(tree.exists('libs/my-lib/src/lib/my-lib.ts')).toBeTruthy();
expect(tree.exists('libs/my-lib/README.md')).toBeTruthy();
const ReadmeContent = tree.readContent('libs/my-lib/README.md');
expect(ReadmeContent).toContain('nx test my-lib');
}); });
}); });

2
packages/workspace/src/schematics/library/library.ts
View File

@ -22,6 +22,7 @@ import { formatFiles } from '@nrwl/workspace';
import { offsetFromRoot } from '@nrwl/workspace'; import { offsetFromRoot } from '@nrwl/workspace';
import { generateProjectLint, addLintFiles } from '../../utils/lint'; import { generateProjectLint, addLintFiles } from '../../utils/lint';
import { addProjectToNxJsonInTree, libsDir } from '../../utils/ast-utils'; import { addProjectToNxJsonInTree, libsDir } from '../../utils/ast-utils';
import { cliCommand } from '../../core/file-utils';
export interface NormalizedSchema extends Schema { export interface NormalizedSchema extends Schema {
name: string; name: string;
@ -80,6 +81,7 @@ function createFiles(options: NormalizedSchema): Rule {
template({ template({
...options, ...options,
...names(options.name), ...names(options.name),
cliCommand: cliCommand(),
tmpl: '', tmpl: '',
offsetFromRoot: offsetFromRoot(options.projectRoot), offsetFromRoot: offsetFromRoot(options.projectRoot),
hasUnitTestRunner: options.unitTestRunner !== 'none', hasUnitTestRunner: options.unitTestRunner !== 'none',