miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): esbuild generateLockfile according to docs (#18413)

Browse Source
This commit is contained in:
Igor Loskutov 2023-08-01 20:29:38 +07:00 committed by GitHub
parent 48deaec60f
commit a5d6a293aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
e2e/esbuild/src/esbuild.test.ts
View File

@ -51,7 +51,10 @@ describe('EsBuild Plugin', () => {
expect(runCommand(`node dist/libs/${myPkg}/index.cjs`)).toMatch(/Hello/); expect(runCommand(`node dist/libs/${myPkg}/index.cjs`)).toMatch(/Hello/);
// main field should be set correctly in package.json // main field should be set correctly in package.json
checkFilesExist(`dist/libs/${myPkg}/package.json`); checkFilesExist(
`dist/libs/${myPkg}/package.json`,
`dist/libs/${myPkg}/pnpm-lock.yaml`
);
expect(runCommand(`node dist/libs/${myPkg}`)).toMatch(/Hello/); expect(runCommand(`node dist/libs/${myPkg}`)).toMatch(/Hello/);
expect(runCommand(`node dist/libs/${myPkg}/index.cjs`)).toMatch(/Hello/); expect(runCommand(`node dist/libs/${myPkg}/index.cjs`)).toMatch(/Hello/);

1
packages/esbuild/src/executors/esbuild/esbuild.impl.ts
View File

@ -85,6 +85,7 @@ export async function* esbuildExecutor(
...options, ...options,
// TODO(jack): make types generate with esbuild // TODO(jack): make types generate with esbuild
skipTypings: true, skipTypings: true,
generateLockfile: true,
outputFileExtensionForCjs: getOutExtension('cjs', options), outputFileExtensionForCjs: getOutExtension('cjs', options),
excludeLibsInPackageJson: !options.thirdParty, excludeLibsInPackageJson: !options.thirdParty,
updateBuildableProjectDepsInPackageJson: externalDependencies.length > 0, updateBuildableProjectDepsInPackageJson: externalDependencies.length > 0,