From a75143caff510fb849d85eec40ebac08b6d8a61d Mon Sep 17 00:00:00 2001 From: Juri Strumpflohner Date: Wed, 12 May 2021 21:59:05 +0200 Subject: [PATCH] fix(storybook): remove webpack v4 typings (#5638) there are different version potentially installed --- packages/storybook/src/generators/init/init.spec.ts | 1 - packages/storybook/src/generators/init/init.ts | 2 -- packages/storybook/src/utils/versions.ts | 1 - 3 files changed, 4 deletions(-) diff --git a/packages/storybook/src/generators/init/init.spec.ts b/packages/storybook/src/generators/init/init.spec.ts index 5635789827..50a196c1d7 100644 --- a/packages/storybook/src/generators/init/init.spec.ts +++ b/packages/storybook/src/generators/init/init.spec.ts @@ -35,7 +35,6 @@ describe('@nrwl/storybook:init', () => { expect( packageJson.devDependencies['@storybook/addon-knobs'] ).toBeDefined(); - expect(packageJson.devDependencies['@types/webpack']).toBeDefined(); // angular specific expect(packageJson.devDependencies['@storybook/angular']).toBeDefined(); diff --git a/packages/storybook/src/generators/init/init.ts b/packages/storybook/src/generators/init/init.ts index c32d9afa37..c433249732 100644 --- a/packages/storybook/src/generators/init/init.ts +++ b/packages/storybook/src/generators/init/init.ts @@ -15,7 +15,6 @@ import { storybookVersion, svgrVersion, urlLoaderVersion, - webpackTypesVersion, } from '../../utils/versions'; import { isFramework } from '../../utils/utilities'; import { Schema } from './schema'; @@ -29,7 +28,6 @@ function checkDependenciesInstalled(host: Tree, schema: Schema) { // base deps devDependencies['@nrwl/storybook'] = nxVersion; - devDependencies['@types/webpack'] = webpackTypesVersion; /** * If Storybook already exists, do NOT update it to the latest version. diff --git a/packages/storybook/src/utils/versions.ts b/packages/storybook/src/utils/versions.ts index eeb3899c12..ae7ca7dd6d 100644 --- a/packages/storybook/src/utils/versions.ts +++ b/packages/storybook/src/utils/versions.ts @@ -3,6 +3,5 @@ export const storybookVersion = '^6.1.11'; export const babelCoreVersion = '7.12.13'; export const babelLoaderVersion = '8.1.0'; export const babelPresetTypescriptVersion = '7.12.13'; -export const webpackTypesVersion = '4.41.21'; export const svgrVersion = '^5.4.0'; export const urlLoaderVersion = '^3.0.0';