From afcf7ba19feda88478ef5e7c7c09eaebc59e5deb Mon Sep 17 00:00:00 2001 From: Jason Jean Date: Wed, 12 Apr 2023 16:31:46 -0400 Subject: [PATCH] feat(core): remove usage of --legacy-peer-deps (#16271) --- e2e/utils/command-utils.ts | 4 ++-- packages/create-nx-workspace/src/utils/package-manager.ts | 2 -- packages/nx/src/nx-init/dot-nx/nxw.ts | 2 +- packages/nx/src/utils/package-manager.ts | 2 -- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/e2e/utils/command-utils.ts b/e2e/utils/command-utils.ts index 4858dc1785..bdc986fed4 100644 --- a/e2e/utils/command-utils.ts +++ b/e2e/utils/command-utils.ts @@ -132,8 +132,8 @@ export function getPackageManagerCommand({ runUninstalledPackage: `npx --yes`, install: 'npm install', ciInstall: 'npm ci', - addProd: `npm install --legacy-peer-deps`, - addDev: `npm install --legacy-peer-deps -D`, + addProd: `npm install`, + addDev: `npm install -D`, list: 'npm ls --depth 10', runLerna: `npx lerna`, }, diff --git a/packages/create-nx-workspace/src/utils/package-manager.ts b/packages/create-nx-workspace/src/utils/package-manager.ts index a7c7585f86..47845e6d70 100644 --- a/packages/create-nx-workspace/src/utils/package-manager.ts +++ b/packages/create-nx-workspace/src/utils/package-manager.ts @@ -62,8 +62,6 @@ export function getPackageManagerCommand( }; case 'npm': - process.env.npm_config_legacy_peer_deps = - process.env.npm_config_legacy_peer_deps ?? 'true'; return { install: 'npm install --silent --ignore-scripts', exec: 'npx', diff --git a/packages/nx/src/nx-init/dot-nx/nxw.ts b/packages/nx/src/nx-init/dot-nx/nxw.ts index 429a886e78..344a9a90d7 100644 --- a/packages/nx/src/nx-init/dot-nx/nxw.ts +++ b/packages/nx/src/nx-init/dot-nx/nxw.ts @@ -78,7 +78,7 @@ function ensureUpToDateInstallation() { }, }) ); - cp.execSync('npm i --legacy-peer-deps', { + cp.execSync('npm i', { cwd: path.dirname(installationPath), stdio: 'inherit', }); diff --git a/packages/nx/src/utils/package-manager.ts b/packages/nx/src/utils/package-manager.ts index c41165b979..e613806e49 100644 --- a/packages/nx/src/utils/package-manager.ts +++ b/packages/nx/src/utils/package-manager.ts @@ -87,8 +87,6 @@ export function getPackageManagerCommand( }; }, npm: () => { - process.env.npm_config_legacy_peer_deps ??= 'true'; - return { install: 'npm install', ciInstall: 'npm ci',