fix(core): nx init should setup default base correctly (#17050)

This commit is contained in:
Craigory Coppola 2023-05-16 10:56:19 -04:00 committed by GitHub
parent 343edf5745
commit c7a6b4ba6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -52,17 +52,17 @@ export function createNxJsonFile(
// eslint-disable-next-line no-empty // eslint-disable-next-line no-empty
} catch {} } catch {}
nxJson.tasksRunnerOptions ||= {}; nxJson.tasksRunnerOptions ??= {};
nxJson.tasksRunnerOptions.default ||= {}; nxJson.tasksRunnerOptions.default ??= {};
nxJson.tasksRunnerOptions.default.runner ||= 'nx/tasks-runners/default'; nxJson.tasksRunnerOptions.default.runner ??= 'nx/tasks-runners/default';
nxJson.tasksRunnerOptions.default.options ||= {}; nxJson.tasksRunnerOptions.default.options ??= {};
nxJson.tasksRunnerOptions.default.options.cacheableOperations = nxJson.tasksRunnerOptions.default.options.cacheableOperations =
cacheableOperations; cacheableOperations;
if (targetDefaults.length > 0) { if (targetDefaults.length > 0) {
nxJson.targetDefaults ||= {}; nxJson.targetDefaults ??= {};
for (const scriptName of targetDefaults) { for (const scriptName of targetDefaults) {
nxJson.targetDefaults[scriptName] ||= {}; nxJson.targetDefaults[scriptName] ??= {};
nxJson.targetDefaults[scriptName] = { dependsOn: [`^${scriptName}`] }; nxJson.targetDefaults[scriptName] = { dependsOn: [`^${scriptName}`] };
} }
for (const [scriptName, output] of Object.entries(scriptOutputs)) { for (const [scriptName, output] of Object.entries(scriptOutputs)) {
@ -70,11 +70,12 @@ export function createNxJsonFile(
// eslint-disable-next-line no-continue // eslint-disable-next-line no-continue
continue; continue;
} }
nxJson.targetDefaults[scriptName] ||= {}; nxJson.targetDefaults[scriptName] ??= {};
nxJson.targetDefaults[scriptName].outputs = [`{projectRoot}/${output}`]; nxJson.targetDefaults[scriptName].outputs = [`{projectRoot}/${output}`];
} }
} }
nxJson.defaultBase = deduceDefaultBase(); nxJson.affected ??= {};
nxJson.affected.defaultBase ??= deduceDefaultBase();
writeJsonFile(nxJsonPath, nxJson); writeJsonFile(nxJsonPath, nxJson);
} }