From ce6caba1f9cfb4f61ef142c40d1ea30a421ffa9a Mon Sep 17 00:00:00 2001
From: Jack Hsu <jack.hsu@gmail.com>
Date: Wed, 20 Nov 2024 09:48:01 -0500
Subject: [PATCH] chore(repo): ensure playwright is installed before running
 e2e tests (#29006)

We're using Playwright by default, but the e2e test is ensuring Cypress
installation.

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
---
 .nx/workflows/agents.yaml | 4 ++--
 e2e/next/src/next.test.ts | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.nx/workflows/agents.yaml b/.nx/workflows/agents.yaml
index 4b136c16b6..2b00aa184b 100644
--- a/.nx/workflows/agents.yaml
+++ b/.nx/workflows/agents.yaml
@@ -38,7 +38,7 @@ launch-templates:
       - name: Install Browsers
         script: |
           pnpm exec cypress install
-          pnpm exec playwright install
+          pnpm exec playwright install --with-deps
 
       - name: Install Rust
         script: |
@@ -95,7 +95,7 @@ launch-templates:
       - name: Install Browsers
         script: |
           pnpm exec cypress install
-          pnpm exec playwright install
+          pnpm exec playwright install --with-deps
 
       - name: Install Rust
         script: |
diff --git a/e2e/next/src/next.test.ts b/e2e/next/src/next.test.ts
index 695c109ca0..5cc90aeaa6 100644
--- a/e2e/next/src/next.test.ts
+++ b/e2e/next/src/next.test.ts
@@ -184,7 +184,7 @@ describe('Next.js Applications', () => {
 
     runCLI(`generate @nx/next:app ${appName} --no-interactive --style=css`);
 
-    if (runE2ETests('cypress')) {
+    if (runE2ETests('playwright')) {
       const e2eResults = runCLI(`e2e-ci ${appName}-e2e --verbose`, {
         verbose: true,
         env: {