miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(js): respect "watch" option when "runBuildTargetDependencies" is true (#27677)

Browse Source 
This PR fixes and issue when `watch: false` and
`runBuildTargetDependencies: true` results in the server process
restarting, but no build happens.

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #20963
This commit is contained in:
Jack Hsu 2024-08-28 14:09:45 -04:00 committed by GitHub
parent adcefcc6da
commit d1c901df1e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/js/src/executors/node/node.impl.ts
View File

@ -276,8 +276,10 @@ export async function* nodeExecutor(
} else if (err) { } else if (err) {
logger.error(`Watch error: ${err?.message ?? 'Unknown'}`); logger.error(`Watch error: ${err?.message ?? 'Unknown'}`);
} else { } else {
logger.info(`NX File change detected. Restarting...`); if (options.watch) {
await runBuild(); logger.info(`NX File change detected. Restarting...`);
await runBuild();
}
} }
} }
); );