From d2272fdebd0b9b65c10138445227e2d26c6891c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Leosvel=20P=C3=A9rez=20Espinosa?= Date: Fri, 9 Feb 2024 14:13:17 +0100 Subject: [PATCH] fix(misc): pin generated vite version to ~5.0.0 to avoid issues with storybook (#21740) --- e2e/nuxt/src/nuxt.test.ts | 2 +- e2e/storybook/src/storybook.test.ts | 2 +- e2e/vue/src/vue-storybook.test.ts | 2 +- packages/cypress/src/utils/versions.ts | 2 +- packages/storybook/src/utils/versions.ts | 2 +- .../vite/src/generators/init/__snapshots__/init.spec.ts.snap | 2 +- packages/vite/src/utils/versions.ts | 2 +- .../src/generators/library/__snapshots__/library.spec.ts.snap | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/e2e/nuxt/src/nuxt.test.ts b/e2e/nuxt/src/nuxt.test.ts index 5f2eeda4a9..58e592bed6 100644 --- a/e2e/nuxt/src/nuxt.test.ts +++ b/e2e/nuxt/src/nuxt.test.ts @@ -12,7 +12,7 @@ describe('Nuxt Plugin', () => { beforeAll(() => { newProject({ - packages: ['@nx/nuxt', '@nx/storybook'], + packages: ['@nx/nuxt'], unsetProjectNameAndRootFormat: false, }); runCLI( diff --git a/e2e/storybook/src/storybook.test.ts b/e2e/storybook/src/storybook.test.ts index 089edcee70..0e34fb9803 100644 --- a/e2e/storybook/src/storybook.test.ts +++ b/e2e/storybook/src/storybook.test.ts @@ -16,7 +16,7 @@ describe('Storybook generators and executors for monorepos', () => { let proj; beforeAll(async () => { proj = newProject({ - packages: ['@nx/react', '@nx/storybook'], + packages: ['@nx/react'], unsetProjectNameAndRootFormat: false, }); runCLI( diff --git a/e2e/vue/src/vue-storybook.test.ts b/e2e/vue/src/vue-storybook.test.ts index c66314338d..a68fbf7b2a 100644 --- a/e2e/vue/src/vue-storybook.test.ts +++ b/e2e/vue/src/vue-storybook.test.ts @@ -15,7 +15,7 @@ describe('Storybook generators and executors for Vue projects', () => { originalEnv = process.env.NX_ADD_PLUGINS; process.env.NX_ADD_PLUGINS = 'true'; proj = newProject({ - packages: ['@nx/vue', '@nx/storybook'], + packages: ['@nx/vue'], unsetProjectNameAndRootFormat: false, }); runCLI( diff --git a/packages/cypress/src/utils/versions.ts b/packages/cypress/src/utils/versions.ts index 32ec275f30..9af321e0fd 100644 --- a/packages/cypress/src/utils/versions.ts +++ b/packages/cypress/src/utils/versions.ts @@ -5,5 +5,5 @@ export const cypressViteDevServerVersion = '^2.2.1'; export const cypressVersion = '^13.0.0'; export const cypressWebpackVersion = '^2.0.0'; export const webpackHttpPluginVersion = '^5.5.0'; -export const viteVersion = '^5.0.0'; +export const viteVersion = '~5.0.0'; export const htmlWebpackPluginVersion = '^5.5.0'; diff --git a/packages/storybook/src/utils/versions.ts b/packages/storybook/src/utils/versions.ts index 6a85ff3066..8727d863d0 100644 --- a/packages/storybook/src/utils/versions.ts +++ b/packages/storybook/src/utils/versions.ts @@ -8,6 +8,6 @@ export const tsLibVersion = '^2.3.0'; export const storybookVersion = '^7.5.3'; export const reactVersion = '^18.2.0'; -export const viteVersion = '^5.0.0'; +export const viteVersion = '~5.0.0'; export const coreJsVersion = '^3.6.5'; diff --git a/packages/vite/src/generators/init/__snapshots__/init.spec.ts.snap b/packages/vite/src/generators/init/__snapshots__/init.spec.ts.snap index b119b03dcc..59f6d546a4 100644 --- a/packages/vite/src/generators/init/__snapshots__/init.spec.ts.snap +++ b/packages/vite/src/generators/init/__snapshots__/init.spec.ts.snap @@ -10,7 +10,7 @@ exports[`@nx/vite:init dependencies for package.json should add required package "@nx/web": "0.0.1", "@vitest/ui": "^1.0.4", "existing": "1.0.0", - "vite": "^5.0.0", + "vite": "~5.0.0", "vitest": "^1.0.4", }, "name": "@proj/source", diff --git a/packages/vite/src/utils/versions.ts b/packages/vite/src/utils/versions.ts index c27c03d5c8..c9f67abfb5 100644 --- a/packages/vite/src/utils/versions.ts +++ b/packages/vite/src/utils/versions.ts @@ -1,5 +1,5 @@ export const nxVersion = require('../../package.json').version; -export const viteVersion = '^5.0.0'; +export const viteVersion = '~5.0.0'; export const vitestVersion = '^1.0.4'; export const vitePluginReactVersion = '^4.2.0'; export const vitePluginReactSwcVersion = '^3.5.0'; diff --git a/packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap b/packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap index f20af10a7f..133d166555 100644 --- a/packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap +++ b/packages/vue/src/generators/library/__snapshots__/library.spec.ts.snap @@ -196,7 +196,7 @@ exports[`lib should add vue, vite and vitest to package.json 1`] = ` "jsdom": "~22.1.0", "prettier": "^2.6.2", "typescript": "~5.3.2", - "vite": "^5.0.0", + "vite": "~5.0.0", "vitest": "^1.0.4", "vue-tsc": "^1.8.8", },