miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

feat(detox): upgrade @config-plugins/detox to 6 (#18345)

Browse Source
This commit is contained in:
Emily Xiong 2023-07-28 11:39:16 -04:00 committed by GitHub
parent cfeb697895
commit d65736e125
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
e2e/expo/src/expo.test.ts
View File

@ -105,9 +105,7 @@ describe('expo', () => {
expect(prebuildResult.combinedOutput).toContain('Config synced');
});
// TODO(emily): this test failed due to version conflict with conflict with @config-plugins/detox
// https://github.com/expo/config-plugins/issues/178
xit('should install', async () => {
it('should install', async () => {
// run install command
const installResults = await runCLIAsync(
`install ${appName} --no-interactive`

13
packages/detox/migrations.json
View File

@ -250,6 +250,19 @@
"alwaysAddToPackageJson": false
}
}
},
"16.6.0": {
"version": "16.6.0-beta.6",
"packages": {
"detox": {
"version": "^20.11.1",
"alwaysAddToPackageJson": false
},
"@config-plugins/detox": {
"version": "~6.0.0",
"alwaysAddToPackageJson": false
}
}
}
}
}

2
packages/detox/src/executors/build/schema.d.ts vendored
View File

@ -1,4 +1,4 @@
// options from https://github.com/wix/Detox/blob/master/docs/APIRef.DetoxCLI.md#build
// options from https://github.com/wix/Detox/blob/master/docs/cli/build.md
export interface DetoxBuildOptions {
detoxConfiguration?: string;
configPath?: string;

4
packages/detox/src/utils/versions.ts
View File

@ -1,5 +1,5 @@
export const nxVersion = require('../../package.json').version;
export const detoxVersion = '^20.9.0';
export const detoxVersion = '^20.11.1';
export const testingLibraryJestDom = '5.16.5';
export const configPluginsDetoxVersion = '~5.0.1'; // only required for expo
export const configPluginsDetoxVersion = '~6.0.0'; // only required for expo

2
packages/expo/src/migrations/update-16-6-0/update-metro-config.ts
View File

@ -54,7 +54,7 @@ const customConfig = {
resolver: {
assetExts: assetExts.filter((ext) => ext !== 'svg'),
sourceExts: [...sourceExts, 'svg'],
blockList: exclusionList([/^(?!.*node_modules).*\/dist\/.*/]),
blockList: exclusionList([/^(?!.*node_modules).*\\/dist\\/.*/]),
unstable_enableSymlinks: true,
unstable_enablePackageExports: true,
},

2
packages/react-native/src/migrations/update-16-6-0/update-metro-config.ts
View File

@ -53,7 +53,7 @@ const customConfig = {
resolver: {
assetExts: assetExts.filter((ext) => ext !== 'svg'),
sourceExts: [...sourceExts, 'svg'],
blockList: exclusionList([/^(?!.*node_modules).*\/dist\/.*/]),
blockList: exclusionList([/^(?!.*node_modules).*\\/dist\\/.*/]),
unstable_enableSymlinks: true,
unstable_enablePackageExports: true,
},