miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(storybook): make sure skipLibCheck is true (#18212)

Browse Source
This commit is contained in:
Katerina Skroumpelou 2023-07-20 18:17:13 +03:00 committed by GitHub
parent c97a8ac63b
commit d942e7b5fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/storybook/src/generators/configuration/configuration.ts
View File

@ -23,6 +23,7 @@ import {
configureTsSolutionConfig,
createProjectStorybookDir,
createStorybookTsconfigFile,
editTsconfigBaseJson,
getE2EProjectName,
getViteConfigFilePath,
projectIsRootProjectInStandaloneWorkspace,
@ -128,6 +129,7 @@ export async function configurationGenerator(
);
}
configureTsProjectConfig(tree, schema);
editTsconfigBaseJson(tree);
configureTsSolutionConfig(tree, schema);
updateLintConfig(tree, schema);

18
packages/storybook/src/generators/configuration/lib/util-functions.ts
View File

@ -28,6 +28,7 @@ import {
import { StorybookConfigureSchema } from '../schema';
import { UiFramework7 } from '../../../utils/models';
import { nxVersion } from '../../../utils/versions';
import ts = require('typescript');
const DEFAULT_PORT = 4400;
@ -259,6 +260,23 @@ export function createStorybookTsconfigFile(
writeJson(tree, storybookTsConfigPath, storybookTsConfig);
}
export function editTsconfigBaseJson(tree: Tree) {
let tsconfigBasePath = 'tsconfig.base.json';
// standalone workspace maybe
if (!tree.exists(tsconfigBasePath)) tsconfigBasePath = 'tsconfig.json';
if (!tree.exists(tsconfigBasePath)) return;
const tsconfigBaseContent = readJson<TsConfig>(tree, tsconfigBasePath);
if (!tsconfigBaseContent.compilerOptions)
tsconfigBaseContent.compilerOptions = {};
tsconfigBaseContent.compilerOptions.skipLibCheck = true;
writeJson(tree, tsconfigBasePath, tsconfigBaseContent);
}
export function configureTsProjectConfig(
tree: Tree,
schema: StorybookConfigureSchema