miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(misc): add cloud token during new workspace like expected (#27265)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

The nx cloud access token is not written to nx.json during
`create-nx-workspace`

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

The nx cloud access token is written to nx.json during
`create-nx-workspace`

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Jason Jean 2024-08-01 17:13:41 -05:00 committed by GitHub
parent 239f47c8d0
commit dacf0b0e18
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/create-nx-workspace/src/utils/nx/nx-cloud.ts
View File

@ -21,11 +21,14 @@ export async function setupNxCloud(
// nx-ignore-next-line // nx-ignore-next-line
)) as typeof import('nx/src/command-line/connect/connect-to-nx-cloud'); )) as typeof import('nx/src/command-line/connect/connect-to-nx-cloud');
const accessToken = await connectWorkspaceToCloud({ const accessToken = await connectWorkspaceToCloud(
installationSource: 'create-nx-workspace', {
directory, installationSource: 'create-nx-workspace',
github: useGitHub, directory,
}); github: useGitHub,
},
directory
);
nxCloudSpinner.succeed('Nx Cloud has been set up successfully'); nxCloudSpinner.succeed('Nx Cloud has been set up successfully');
return accessToken; return accessToken;

7
packages/nx/src/command-line/connect/connect-to-nx-cloud.ts
View File

@ -56,12 +56,13 @@ export async function connectToNxCloudIfExplicitlyAsked(
} }
export async function connectWorkspaceToCloud( export async function connectWorkspaceToCloud(
options: ConnectToNxCloudOptions options: ConnectToNxCloudOptions,
directory = workspaceRoot
) { ) {
const tree = new FsTree(workspaceRoot, false, 'connect-to-nx-cloud'); const tree = new FsTree(directory, false, 'connect-to-nx-cloud');
const accessToken = await connectToNxCloud(tree, options); const accessToken = await connectToNxCloud(tree, options);
tree.lock(); tree.lock();
flushChanges(workspaceRoot, tree.listChanges()); flushChanges(directory, tree.listChanges());
return accessToken; return accessToken;
} }