miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(core): nx plugin cache should load new plugins (#15072)

Browse Source
This commit is contained in:
Craigory Coppola 2023-02-17 16:17:03 -05:00 committed by GitHub
parent 1e6a4f8e65
commit e575c49c3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/nx/src/utils/nx-plugin.ts
View File

@ -47,7 +47,7 @@ export interface NxPlugin {
// holding resolved nx plugin objects. // holding resolved nx plugin objects.
// Allows loadNxPlugins to be called multiple times w/o // Allows loadNxPlugins to be called multiple times w/o
// executing resolution mulitple times. // executing resolution mulitple times.
let nxPluginCache: NxPlugin[] = null; let nxPluginCache: Map<string, NxPlugin> = new Map();
function loadNxPlugin(moduleName: string, paths: string[], root: string) { function loadNxPlugin(moduleName: string, paths: string[], root: string) {
let pluginPath: string; let pluginPath: string;
@ -98,13 +98,16 @@ export function loadNxPlugins(
result.push(jsPlugin as NxPlugin); result.push(jsPlugin as NxPlugin);
plugins ??= []; plugins ??= [];
if (!nxPluginCache) { for (const plugin of plugins) {
nxPluginCache = plugins.map((moduleName) => let pluginModule = nxPluginCache.get(plugin);
loadNxPlugin(moduleName, paths, root) if (!pluginModule) {
); pluginModule = loadNxPlugin(plugin, paths, root);
nxPluginCache.set(plugin, pluginModule);
}
result.push(pluginModule);
} }
return result.concat(nxPluginCache); return result;
} }
export function mergePluginTargetsWithNxTargets( export function mergePluginTargetsWithNxTargets(