miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

fix(linter): adjust terminal run check for crystal (#21638)

Browse Source
This commit is contained in:
Miroslav Jonaš 2024-02-06 15:32:54 +01:00 committed by GitHub
parent ab5137c639
commit f79aabba46
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
e2e/eslint/src/linter.test.ts
View File

@ -462,8 +462,7 @@ describe('Linter', () => {
}); });
}); });
// TODO(crystal, @meeroslav): Investigate why this is failing it('should report dependency check issues', () => {
xit('should report dependency check issues', () => {
const rootPackageJson = readJson('package.json'); const rootPackageJson = readJson('package.json');
const nxVersion = rootPackageJson.devDependencies.nx; const nxVersion = rootPackageJson.devDependencies.nx;
const tslibVersion = rootPackageJson.dependencies['tslib']; const tslibVersion = rootPackageJson.dependencies['tslib'];
@ -476,7 +475,7 @@ describe('Linter', () => {
`libs/${mylib}/src/lib/${mylib}.ts`, `libs/${mylib}/src/lib/${mylib}.ts`,
(content) => (content) =>
`import { names } from '@nx/devkit';\n\n` + `import { names } from '@nx/devkit';\n\n` +
content.replace(/=> .*;/, `=> names(${mylib}).className;`) content.replace(/=> .*;/, `=> names('${mylib}').className;`)
); );
// output should now report missing dependency // output should now report missing dependency

2
packages/eslint-plugin/src/utils/runtime-lint-utils.ts
View File

@ -416,7 +416,7 @@ export function hasBuildExecutor(
); );
} }
const ESLINT_REGEX = /node_modules.*[\/\\]eslint$/; const ESLINT_REGEX = /node_modules.*[\/\\]eslint(?:\.js)?$/;
const JEST_REGEX = /node_modules\/.bin\/jest$/; // when we run unit tests in jest const JEST_REGEX = /node_modules\/.bin\/jest$/; // when we run unit tests in jest
const NRWL_CLI_REGEX = /nx[\/\\]bin[\/\\]run-executor\.js$/; const NRWL_CLI_REGEX = /nx[\/\\]bin[\/\\]run-executor\.js$/;