miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(gatsby): remove npm_config_legacy_peer_deps (#6698)

Browse Source
This commit is contained in:
Emily Xiong 2021-08-12 12:47:46 -04:00 committed by GitHub
parent 3351ef80bc
commit f96c5371c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
e2e/workspace/src/create-nx-workspace.test.ts
View File

@ -94,7 +94,7 @@ describe('create-nx-workspace', () => {
const wsName = uniq('gatsby'); const wsName = uniq('gatsby');
const appName = uniq('app'); const appName = uniq('app');
runCreateWorkspace(wsName, { runCreateWorkspace(wsName, {
preset: 'next', preset: 'gatsby',
style: 'css', style: 'css',
appName, appName,
packageManager, packageManager,

4
packages/create-nx-workspace/bin/create-nx-workspace.ts
View File

@ -486,10 +486,6 @@ async function createApp(
nxWorkspaceRoot = `\\"${nxWorkspaceRoot.slice(1, -1)}\\"`; nxWorkspaceRoot = `\\"${nxWorkspaceRoot.slice(1, -1)}\\"`;
} }
} }
// For gatsby, when doing npm install, it does not require the flag --legacy-peer-deps
if (parsedArgs.preset === Preset.Gatsby && packageManager === 'npm') {
process.env.npm_config_legacy_peer_deps = 'false';
}
const fullCommandWithoutWorkspaceRoot = `${pmc.exec} tao ${command}/generators.json --cli=${cli}`; const fullCommandWithoutWorkspaceRoot = `${pmc.exec} tao ${command}/generators.json --cli=${cli}`;
let workspaceSetupSpinner = ora('Creating your workspace').start(); let workspaceSetupSpinner = ora('Creating your workspace').start();

1
packages/gatsby/src/generators/init/init.ts
View File

@ -42,7 +42,6 @@ function updateDependencies(host: Tree) {
}); });
const isPnpm = host.exists('pnpm-lock.yaml'); const isPnpm = host.exists('pnpm-lock.yaml');
process.env.npm_config_legacy_peer_deps = 'false';
return addDependenciesToPackageJson( return addDependenciesToPackageJson(
host, host,
{ {