miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(testing): remove 'swc' from compiler option for jest generators

Browse Source 
@swc/jest is not currently working as it's supposed to. at least, with single .swcrc file.
This commit is contained in:
Chau Tran 2021-12-23 15:27:57 -06:00 committed by Victor Savkin
parent d6d56c7c4e
commit f97961d865
7 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/jest/src/generators/init/init.spec.ts
View File

@ -58,13 +58,11 @@ describe('jest', () => {
expect(packageJson.devDependencies['babel-jest']).toBeDefined(); expect(packageJson.devDependencies['babel-jest']).toBeDefined();
}); });
it('should support swc compiler', () => { // it('should support swc compiler', () => {
jestInitGenerator(tree, { compiler: 'swc' }); // jestInitGenerator(tree, { compiler: 'swc' });
const packageJson = readJson(tree, 'package.json'); // const packageJson = readJson(tree, 'package.json');
// expect(packageJson.devDependencies['@swc/jest']).toBeDefined(); // expect(packageJson.devDependencies['@swc/jest']).toBeDefined()
// TODO: change back to @swc/jest when we use @swc/jest // });
expect(packageJson.devDependencies['ts-jest']).toBeDefined();
});
}); });
describe('adds jest extension', () => { describe('adds jest extension', () => {

7
packages/jest/src/generators/init/init.ts
View File

@ -66,12 +66,11 @@ function updateDependencies(tree: Tree, options: NormalizedSchema) {
'@types/jest': jestTypesVersion, '@types/jest': jestTypesVersion,
}; };
// TODO: revert to @swc/jest when https://github.com/swc-project/cli/issues/20 is addressed
// } else if (options.compiler === 'swc') {
// devDeps['@swc/jest'] = swcJestVersion;
if (options.compiler === 'babel' || options.babelJest) { if (options.compiler === 'babel' || options.babelJest) {
devDeps['babel-jest'] = babelJestVersion; devDeps['babel-jest'] = babelJestVersion;
} else if (options.compiler === 'swc') {
// TODO: revert to @swc/jest when https://github.com/swc-project/cli/issues/20 is addressed
// devDeps['@swc/jest'] = swcJestVersion;
devDeps['ts-jest'] = tsJestVersion;
} else { } else {
devDeps['ts-jest'] = tsJestVersion; devDeps['ts-jest'] = tsJestVersion;
} }

2
packages/jest/src/generators/init/schema.d.ts vendored
View File

@ -1,5 +1,5 @@
export interface JestInitSchema { export interface JestInitSchema {
compiler?: 'tsc' | 'swc' | 'babel'; compiler?: 'tsc' | 'babel';
/** /**
* @deprecated * @deprecated
*/ */

4
packages/jest/src/generators/jest-project/lib/create-files.ts
View File

@ -13,11 +13,11 @@ export function createFiles(tree: Tree, options: JestProjectSchema) {
const filesFolder = const filesFolder =
options.setupFile === 'angular' ? '../files-angular' : '../files'; options.setupFile === 'angular' ? '../files-angular' : '../files';
// } else if (options.compiler === 'swc') {
// transformer = '@swc/jest';
let transformer: string; let transformer: string;
if (options.compiler === 'babel' || options.babelJest) { if (options.compiler === 'babel' || options.babelJest) {
transformer = 'babel-jest'; transformer = 'babel-jest';
} else if (options.compiler === 'swc') {
transformer = '@swc/jest';
} else { } else {
transformer = 'ts-jest'; transformer = 'ts-jest';
} }

2
packages/jest/src/generators/jest-project/schema.d.ts vendored
View File

@ -13,5 +13,5 @@ export interface JestProjectSchema {
*/ */
babelJest?: boolean; babelJest?: boolean;
skipFormat?: boolean; skipFormat?: boolean;
compiler?: 'tsc' | 'swc' | 'babel'; compiler?: 'tsc' | 'babel';
} }

2
packages/jest/src/generators/jest-project/schema.json
View File

@ -42,7 +42,7 @@
}, },
"compiler": { "compiler": {
"type": "string", "type": "string",
"enum": ["tsc", "swc", "babel"], "enum": ["tsc", "babel"],
"description": "The compiler to use for source and tests", "description": "The compiler to use for source and tests",
"default": "tsc" "default": "tsc"
}, },

2
packages/js/src/utils/project-generator.ts
View File

@ -225,7 +225,7 @@ async function addJest(
skipSerializers: true, skipSerializers: true,
testEnvironment: options.testEnvironment, testEnvironment: options.testEnvironment,
skipFormat: true, skipFormat: true,
compiler: options.compiler, compiler: options.compiler as 'tsc',
}); });
} }