37 Commits

Author SHA1 Message Date
MaxKless
499300fd76
fix(core): repair SIGINT signals on windows (#28496)
using `windowsHide: true` is causing an issue on windows: Ctrl + C
handling isn't enabled and no `SIGINT` is sent to the child process when
users exit the process. See https://github.com/nodejs/node/issues/29837
and https://github.com/nodejs/node-v0.x-archive/issues/5054 for
reference. This will cause leftover processes throughout nx.

This PR sets `windowsHide: false` everywhere except for the plugin
workers and some short-lived utils. They `spawn` child processes but
have explicit handling to make sure they kill themselves when the parent
process dies, so the missing Ctrl + C handling doesn't cause issues.

We will follow up to make sure any other culprits that still cause
windows popups (especially when used through Nx Console) are handled.
Leaving no leftover processes running is more important for now, though.

Keep in mind the underlying tooling (like vite) might have some windows
popups themselves that Nx will inherit.
2024-10-17 15:03:37 -04:00
MaxKless
b73f1e0e00
fix(core): set windowsHide: true wherever possible (#28073)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-09-24 11:31:22 -04:00
Jason Jean
bb92857b21
chore(repo): make publishing depend on build targets (#27080)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Populating the local registry for e2e tests is not dependent on the
builds but runs them. It sometimes gets cache misses for some builds
thus making that inconsistent.


https://staging.nx.app/runs/FxIwbj6UQo/task/%40nx%2Fnx-source%3Apopulate-local-registry-storage

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Populating the local registry for e2e tests is dependent on the builds
and does not run them within itself. In the CI pipeline, this ensures
that the build tasks are run first.


https://staging.nx.app/runs/NUrFeUBbQk/task/%40nx%2Fnx-source%3Apopulate-local-registry-storage

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-07-24 15:46:09 -04:00
James Henry
472459d9f5
chore(repo): allow e2e workflows to publish relative versions (#26609) 2024-06-21 00:11:35 +04:00
James Henry
42749b8225
chore(repo): refactor publish.yml for PR releases (#26550)
Redo of #26509, with more guards for unexpected missing/relative values
within full releases in GitHub Actions.

---

Refactors our publish workflow to support PR releases, in addition to
our previous triggers.

**Tests:**

---

- Example of failure on non-PR release (comment skipped):
https://github.com/nrwl/nx/actions/runs/9480869812

---

- Example of failure on PR release (comment created on PR):
  - https://github.com/nrwl/nx/actions/runs/9480852880
  - https://github.com/nrwl/nx/pull/26515#issuecomment-2162646682

---

- Example of dry-run of full release (`workflow_dispatch` with no PR
number provided): https://github.com/nrwl/nx/actions/runs/9497871483

---

- Real PR release created here:

| Release details | 📑 |
  | ------------- | ------------- |
| **Published version** |
[0.0.0-pr-26515-856ef7f](https://www.npmjs.com/package/nx/v/0.0.0-pr-26515-856ef7f)
|
  | **Triggered by** | @JamesHenry |
| **Branch** |
[JamesHenry-patch-1](https://github.com/nrwl/nx/tree/JamesHenry-patch-1)
|
| **Commit** |
[856ef7f](856ef7f353)
|
| **Workflow run** |
[9497298216](https://github.com/nrwl/nx/actions/runs/9497298216) |

---------

Co-authored-by: Katerina Skroumpelou <sk.katherine@gmail.com>
2024-06-14 07:07:06 -04:00
Jason Jean
73c8c3343d
Revert publish (#26544)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

The below commit caused the publish pipeline to publish a `minor`
version when it should have been a `next` version.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

This reverts commit
3750366ebc.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-06-13 14:27:36 -04:00
James Henry
3750366ebc
chore(repo): refactor publish.yml for PR releases (#26509) 2024-06-13 09:28:43 -04:00
James Henry
1d6e0f8c67
chore(repo): only valid latest publish when not local (#22131) 2024-03-04 17:23:00 +04:00
James Henry
80ae3971ff
chore(repo): check valid release authors for latest (#22127) 2024-03-04 07:20:21 -05:00
Austin Fahsl
69636ad7ba
fix(release): do not restart the daemon when skipLockFileUpdate is set (#21389) 2024-01-29 23:07:16 +04:00
Miroslav Jonaš
17b09b9ba1
fix(repo): fix version calculation on nx-release (#21382) 2024-01-29 16:48:26 +04:00
James Henry
c577f48cea
fix(release): only add nx-release-publish to public packages (#21338) 2024-01-26 11:56:54 -05:00
Miroslav Jonaš
fc8cca44c5
chore(repo): print version at the end of nx-release script (#21346) 2024-01-26 17:03:38 +04:00
Jason Jean
cfd8c898eb
fix(repo): fix release script to look for new node auth token (#20590) 2023-12-05 23:59:34 +04:00
James Henry
1b4b463b21
chore(core): add nightly canary release (#20540) 2023-12-02 00:39:04 +04:00
Jason Jean
b4faf2dd3b
fix(core): fix changelog configuration (#20138) 2023-11-08 17:52:17 -05:00
Jason Jean
8ce2905d77
chore(repo): publish minor by default when running nx-release (#19477) 2023-10-06 14:49:24 -04:00
Jason Jean
854d8b83b5
chore(repo): update nx to 16.10.0-beta.1 (#19446) 2023-10-04 16:56:49 -04:00
Jason Jean
5cc87bfdc2
fix(misc): properly add extra dependencies to packages (#19334) 2023-09-26 00:09:29 -04:00
James Henry
6327fab2e0
chore(repo): dogfood nx release commands (#19237) 2023-09-21 13:38:13 -04:00
Jason Jean
8d5a16004d
chore(repo): re-enable macos e2e caching (#18382) 2023-07-31 11:05:48 -04:00
Jason Jean
989f7f8f92
chore(repo): update nx to 16.6.0-beta.8 (#18356) 2023-07-29 10:39:53 -04:00
James Henry
c9d649e57c
chore(core): enable provenance and update lerna usage (#16814) 2023-05-05 13:20:05 -04:00
Miroslav Jonaš
68ae304cda
fix(repo): fix windows nightly runs (#16765) 2023-05-04 10:29:45 -04:00
Miroslav Jonaš
262865841d
feat(repo): migrate to pnpm (#16284) 2023-04-25 17:57:36 -04:00
Jason Jean
5b4015ad89
Revert "chore(misc): update lerna to 6.5.1" (#15578) 2023-03-09 19:25:34 -05:00
Austin Fahsl
c447106eea
chore(misc): update lerna to 6.5.1 (#15482) 2023-03-09 16:31:39 -05:00
Jonathan Cammisuli
24452aac70
chore(core): delete local .node files before publish (#15268) 2023-02-25 20:54:57 -05:00
Jonathan Cammisuli
fecf7fb82f
feat(core): add native node bindings for hashing (#14476)
Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
2023-02-01 14:43:40 -05:00
Jason Jean
cb0ccea9a8
chore(repo): hide vite from being pubished publically (#13060) 2022-11-08 11:31:56 -05:00
Victor Savkin
d8dc1d5911
chore(repo): test change 2022-09-12 13:36:25 -04:00
Jason Jean
292f0c14b1
feat(core): generate inputs configuration for new workspaces (#11856) 2022-09-07 22:32:59 -04:00
Miroslav Jonaš
6a7d95bc39
chore(repo): release major version on e2e runs (#11619) 2022-08-17 12:07:40 +00:00
Miroslav Jonaš
001fed8c3b
chore(core): release canary version for e2e tests to avoid version overlap (#11539) 2022-08-12 16:30:22 +02:00
Jason Jean
049435ce9b
fix(repo): reset git index when terminating publishing (#10689) 2022-06-10 12:38:50 -04:00
Jason Jean
2814a86b4c
fix(repo): update package group during publishing (#10411) 2022-05-24 23:28:10 +00:00
Jason Jean
04985be149
chore(repo): switch publishing to use lerna (#10293) 2022-05-20 00:35:47 +00:00