11 Commits

Author SHA1 Message Date
Jack Hsu
45c458e677
fix(react): generate valid Vite + JSX setup for React (#27130)
The current `@nx/react:app` generator does not take the `--js` option
into account. There are two problems:

1. `index.html` includes `main.tsx` not `main.jsx`.
2. `.js` files with JSX are invalid in Vite, and must be named `.jsx`.

This PR adds a new option to the `toJS` devkit util to preserve `.jsx`
rather than renaming them to `.js`. The vast majority of non-Vite React
projects will use `.js` and not `.jsx` (e.g. Next.js, Expo, Remix, etc.)
so we just want to apply this change to Vite only for now.

In the future we could enhance React generators to support `--jsx`, for
example.

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #20810
2024-07-26 08:30:16 -04:00
Jason Jean
a64a7e2db9
feat(core): cleanup for v19 (#22993) 2024-05-01 12:12:32 -04:00
Craigory Coppola
2374d8eaba
feat(testing): add create-nodes plugin for playwright e2e targets (#20099) 2023-12-20 16:34:32 -05:00
Miroslav Jonaš
2dd59c3b57
feat(core): extract js related code from affected and hasher (#16244) 2023-04-18 10:42:05 -04:00
Jason Jean
3d4f590c07
fix(core): do not add typescript in new empty repos (#15163)
Co-authored-by: Emily Xiong <xiongemi@gmail.com>
2023-02-27 12:08:36 -05:00
Jason Jean
5e23c07077
fix(core): automatically add root to the project.json projects (#9977)
* fix(core): automatically add root to the project.json projects

* chore(core): move project-configuration generator utils to nx package

* fix(core): add migrations to remove root
2022-04-28 13:24:35 -04:00
Victor Savkin
428106f6be
cleanup(core): create more meaningful file structure in nx package (#9621) 2022-03-31 09:07:22 -04:00
Victor Savkin
6f038e7a4a feat(core): reorganize packges to consolidate all cli-related code in nx 2022-03-14 16:42:51 -04:00
Phillip Barta
6c6e8b36b7 feat(devkit): refactoring for stricter types and better performance 2021-05-27 13:37:29 -04:00
vsavkin
2eadc30f21 cleanup(misc): speed up requiring devkit 2021-04-04 11:11:16 -04:00
Jason Jean
716bb44254
feat(core): migrate library to devkit (#4512)
* migrate lint

* feat(core): migrate library to devkit
2021-01-13 16:57:19 -05:00