132 Commits

Author SHA1 Message Date
James Henry
24060dc650
chore(repo): prepopulate verdaccio storage for e2e-ci (#23429) 2024-05-16 10:06:25 -04:00
Nicholas Cunningham
9cd0b420d1
feat(react): Add SvgOptions for NxReactWebpackPlugin and WithNx (#23283)
This PR adds the ability to now override our svg options by providing
them either using `NxReactWebpackPlugin` for react apps or `withNx` for
Next.js apps

```
new NxReactWebpackPlugin({
  svgr: {
    svgo: true,
    titleProp: true,
    ref: true,
  }
}),
  ```

This now gives you control on customizing how the svg is handled. Should you need to enable svgo you can provide the config using `svgr.config.js`

https://react-svgr.com/docs/options/#svgo

closes: #9487
2024-05-13 08:15:44 -06:00
Jack Hsu
2e621f324c
feat(misc): v19 cleanup for Nx plugins (#23104)
This PR removes deprecated code that's been slated for removal in Nx 19
- mentioned as `TODO(v19)` comments.

## Breaking Changes

- **CNW:** `create-nx-workspace` no longer support `--preset=empty` and
`--preset=core`, use `--preset=apps` and `--preset=npm` respectively.
Deprecated in Nx 15.9.
- **Next.js:** `NX_` environment variables are no longer bundled into
Next.js apps, use `NEXT_PUBLIC` instead. Deprecated in Nx 16.8.
- **Webpack, Storybook, Esbuild:** `NX_` environment variables are no
longer bundled into browser bundles, use `NX_PUBLIC` instead. This
removes the possibility of intentional bundling of `NX_` variables.
Deprecated in Nx 18.
- **Cypress:** `cypressComponentConfiguration` generator removed from
`@nx/cypress`, use `configurationGenerator`instead. Deprecated in Nx
16.8.
- **Cypress:** `cypressProjectGenerator` generator removed from
`@nx/cypress`, use `configurationGenerator` instead. Deprecated in Nx
15.9.
- **Expo:** `withNxWebpack` removed from `@nx/expo`, use [metro
bundler](https://docs.expo.dev/guides/customizing-metro/)
(https://docs.expo.dev/guides/customizing-metro/) in app.json instead.
There is a migration to handle this in Nx 19. Deprecated in Nx 15.8.

## Deferred to v20

- **JS:** `classProperties.loose` option removed from `@nx/js/babel`
preset, use `loose` instead. Deprecated in Nx 17.0.
- **ESLint:** Low priority task to "deviations from
@typescript-eslint/recommended" for our lint rules. @JamesHenry will
look at this later before Nx 20, but it is unimportant.
- **React:** component testing does not work with Project Crystal, and
we need the executor + built-in webpack configs to run CT. Will do a
follow-up on this after Nx 19 release. Related issue:
https://github.com/nrwl/nx/issues/21546
- **Next.js:** `withStylus` removal from `@nx/next`, use SASS instead.
It hasn't worked, but we kept the file to throw an error when used.
Deprecated in Nx 17.0.
- **Next.js**: `@nx/next:component` and `@nx/next:page` generators to
not derive the `components` and `app`/`pages` directory. Use `nx g
@nx/next:component apps/myapp/components/button` instead. Deprecated in
Nx 17.0.
- **Webpack:** `isolatedConfig` option removal from
`@nx/webpack:webpack` executor. There is a migration to handle this in
Nx 19. Deprecated in in Nx 17.2.
- **Angular:** `executeWebpackDevServerBuilder` removal from
`@nx/angular/executors`, use `executeDevServerBuilder` instead.
Deprecated in Nx 17.0.
2024-05-02 13:37:12 -04:00
Jason Jean
df7e40d547
feat(repo): split e2e tests (#22927) 2024-04-25 10:13:03 -04:00
Nicholas Cunningham
34a727926b
fix(nextjs): improve e2e test by reusing the project (#18827) 2023-08-25 16:15:52 -04:00
Leosvel Pérez Espinosa
18ba93ad5d
feat(nextjs): use helper to determine project name and root in projects generators (#18733) 2023-08-21 14:42:30 +01:00
Emily Xiong
40d66ec715
chore(core): remove readProjectsConfigurations from workspaces (#18329)
Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
2023-08-15 14:48:40 -04:00
Emily Xiong
107a7536b8
fix(testing): make the default react playwright test to pass (#18559) 2023-08-11 10:37:28 -04:00
Caleb Ukle
5e51cd6eb5
fix(testing): playwright plugin clean up (#18447) 2023-08-02 16:14:17 -04:00
Jack Hsu
e78575badc
feat(nextjs): add playwright as an option for e2e testing (#18281) 2023-08-01 10:51:51 -04:00
MaxKless
59f696c85b
cleanup(misc): remove outdated run-e2e-tests targets (#18147) 2023-07-17 15:05:39 -04:00
Nicholas Cunningham
50ee9904e1
fix(nextjs): Respect CLI output path when provided (#17947) 2023-07-04 13:58:13 -06:00
Nicholas Cunningham
3008be1e7a
fix(nextjs): Running nx build --configuration=development should not throw an error (#17866) 2023-06-29 21:18:50 -04:00
Jack Hsu
77ca8d7c33
feat(nextjs): allow withNx to be used with other executors such as run-commands (#17819) 2023-06-27 10:24:26 -04:00
Jack Hsu
fdf755584f
fix(nextjs): update workspace libs setup in weback config (#17795) 2023-06-26 12:26:52 -04:00
Emily Xiong
075ac2545d
chore(repo): change e2e to use verdaccio executor (#17347) 2023-06-07 12:26:43 -04:00
Jack Hsu
a7c6d5aadb
fix(nextjs): adjust generated CSS-in-JS to match latest Next.js recommendations (#17294) 2023-05-30 12:12:39 -04:00
Jack Hsu
b6361738a4
fix(nextjs): support relative imports in next.config.js (#17127) 2023-05-23 14:34:12 -04:00
Jack Hsu
c9cd67ea76 fix(repo): add missing lsof package needed to kill ports 2023-05-19 09:21:41 -04:00
Nicholas Cunningham
8ce9606a5b
feat(nextjs): Add --turbo support (#17069) 2023-05-18 11:17:00 -06:00
Nicholas Cunningham
3d76d95b29
feat(nextjs): Use next.js cli for build and serve targets (#16896) 2023-05-17 11:09:11 -04:00
Jack Hsu
95421c6945
feat(nextjs): update Next.js to 13.4.1 and default to App Router for new apps (#16948) 2023-05-12 16:09:20 -04:00
Jack Hsu
854b180013
fix(nextjs): inline dev-only dependencies and add e2e test to catch issues (#16890) 2023-05-09 13:28:52 -04:00
Miroslav Jonaš
1e8e84777c
fix(nextjs): increase timeout on styles e2e test (#16800) 2023-05-08 14:45:08 -04:00
Jack Hsu
8d35edac39
fix(nextjs): add workspace dependencies to transpilePackages automatically (#16774) 2023-05-04 18:08:34 -04:00
Jack Hsu
66addbfa81
fix(nextjs): with stylus and less support (#16764) 2023-05-04 08:32:44 -06:00
Ahmed Elsakaan
4cab83eb99
chore(nextjs): changes application generator tsconfig strict to true (#14855) 2023-04-26 09:14:48 -04:00
Jason Jean
a0d18bb588
chore(repo): replace references to @nrwl in e2e tests (#16441) 2023-04-24 18:48:44 -04:00
Caleb Ukle
06a885aca2
feat(next): support nextjs cypress component testing (#16292) 2023-04-21 15:15:28 -04:00
Nicholas Cunningham
338dc64d91
feat(nextjs): Add standalone Nextjs option to react selection when running CNW (#16317) 2023-04-19 15:29:31 -04:00
Jason Jean
2d195007b0
feat(core): switch packages to use the @nx scope (#16069) 2023-04-14 19:56:37 -04:00
Jack Hsu
ea34e88473
chore(nextjs): increase test timeout to avoid intermittent failure (#16059) 2023-04-03 09:26:54 -06:00
Jack Hsu
b3200fb7c4
fix(nextjs): set correct distDir when running production server through Nx (#15861) 2023-03-23 16:57:10 +00:00
Jack Hsu
c7e49c564a
fix(nextjs): produce correct next.config.js file for production server (#15824) 2023-03-22 14:03:09 -04:00
Jack Hsu
63cdddfa11
fix(nextjs): handle buildable libs correctly (#15795) 2023-03-21 11:21:02 -04:00
Colum Ferry
80f3d03d1d
feat(core): move string utils to devkit (#15479) 2023-03-10 13:15:47 -05:00
Miroslav Jonaš
088a236306
chore(repo): temporarily disabling flaky next test (#15473) 2023-03-06 10:49:47 -05:00
Jason Jean
92610fe4b6
chore(repo): update nx to 15.8.0-beta.7 (#15293) 2023-02-27 17:24:06 -05:00
Jason Jean
84fedf36e0
Revert "chore(repo): update nx to 15.8.0-beta.6" (#15274) 2023-02-26 12:39:15 -05:00
Jason Jean
3c50474f40
chore(repo): update nx to 15.8.0-beta.6 (#15247) 2023-02-26 02:26:53 -05:00
Caleb Ukle
5ddd657a42
chore(repo): enable cypress in CI (#15155) 2023-02-24 11:16:19 -05:00
Miroslav Jonaš
b80286191d
feat(core): refactor lock file parsing and pruning (#13864)
Co-authored-by: Jason Jean <FrozenPandaz@users.noreply.github.com>
Co-authored-by: Victor Savkin <vsavkin@users.noreply.github.com>
Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
2023-02-06 11:39:36 -05:00
Jack Hsu
d3ba6447d0
fix(nextjs): hide lockfile generation behind a flag so it can be toggled on and off (#14204) 2023-01-06 20:26:10 +00:00
Craigory Coppola
7992ec618f
chore(repo): setup negative config for several targets (#14080) 2023-01-04 11:34:50 -05:00
Jason Jean
4a43a04caf
chore(repo): re-enable next.js styles tests (#13995) 2022-12-22 16:58:12 -05:00
Jason Jean
5e5892f086
chore(repo): update nx to 15.4.0-beta.3 (#13904) 2022-12-20 17:48:03 -05:00
Miroslav Jonaš
75de1651a1
feat(core): add lockfile pruning to executors that generate package.json (#13734) 2022-12-09 12:17:36 -05:00
Jack Hsu
66c85bd15c
cleanup(nextjs): remove workaround for enhanced-resolve bug in e2e test (#13639) 2022-12-05 12:20:18 -05:00
Miroslav Jonaš
1a3cc515a4
fix(core): prevent peer deps from ending up as dev deps in create package json (#13502) 2022-12-01 12:07:52 +01:00
Jack Hsu
98a6cb1e32
chore(repo): re-enable storybook e2e tests with overrides for enhance… (#13339) 2022-11-22 16:49:35 -05:00