29 Commits

Author SHA1 Message Date
MaxKless
499300fd76
fix(core): repair SIGINT signals on windows (#28496)
using `windowsHide: true` is causing an issue on windows: Ctrl + C
handling isn't enabled and no `SIGINT` is sent to the child process when
users exit the process. See https://github.com/nodejs/node/issues/29837
and https://github.com/nodejs/node-v0.x-archive/issues/5054 for
reference. This will cause leftover processes throughout nx.

This PR sets `windowsHide: false` everywhere except for the plugin
workers and some short-lived utils. They `spawn` child processes but
have explicit handling to make sure they kill themselves when the parent
process dies, so the missing Ctrl + C handling doesn't cause issues.

We will follow up to make sure any other culprits that still cause
windows popups (especially when used through Nx Console) are handled.
Leaving no leftover processes running is more important for now, though.

Keep in mind the underlying tooling (like vite) might have some windows
popups themselves that Nx will inherit.
2024-10-17 15:03:37 -04:00
MaxKless
b73f1e0e00
fix(core): set windowsHide: true wherever possible (#28073)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-09-24 11:31:22 -04:00
James Henry
68eeb2eeed
feat(linter): create new workspaces with ESLint v9 and typescript-eslint v8 (#27404)
Closes #27451

---------

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Co-authored-by: Jack Hsu <jack.hsu@gmail.com>
2024-09-12 16:02:27 -04:00
Jordan Hall
80702b59c7
feat(core): add bun package manager (#22602)
Bun uses yarn lock for it's binary file. Running the binary will produce
the content of a yarn lock file (v1)

Other option is to use the -y command on add and install. This will
create a yarn lock file and then createLockFile can just modify the
yarn.lock file instead?

This is the PR made from #19113 and pushed due to #22402 being closed.

PS Bun feels more stable since the PR was first created!

This PR will resolve #22283 and start of #21075
2024-05-22 16:51:21 -04:00
Leosvel Pérez Espinosa
197e670366
cleanup(testing): fix cypress e2e tests (#21551)
Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
2024-02-02 18:03:52 -05:00
Colum Ferry
9be869ff7b
feat(angular): switch default to typescript configuration for module federation (#18998) 2023-10-10 15:36:28 +01:00
Jason Jean
50b62524f5
chore(misc): remove e2e utils that use internal nx functions (#19085) 2023-09-11 19:56:58 -04:00
Emily Xiong
0bb6ab896e
chore(testing): move setMaxWorker out runCLI (#18582) 2023-08-17 11:57:25 -04:00
Emily Xiong
40d66ec715
chore(core): remove readProjectsConfigurations from workspaces (#18329)
Co-authored-by: FrozenPandaz <jasonjean1993@gmail.com>
2023-08-15 14:48:40 -04:00
Katerina Skroumpelou
c0d3aa5697
chore(testing): try catch the pm command detection (#18486) 2023-08-04 14:59:20 +00:00
Caleb Ukle
5e51cd6eb5
fix(testing): playwright plugin clean up (#18447) 2023-08-02 16:14:17 -04:00
Miroslav Jonaš
4a541418bb
fix(repo): fix silent yarn run on e2e for berry (#18340) 2023-07-27 20:39:26 +02:00
Katerina Skroumpelou
36838d6211
fix(js): node executor should always log error (#17622) 2023-06-16 16:45:05 +00:00
Jason Jean
137b743855
fix(misc): restore using legacy-peer-deps for npm installs (#16767) 2023-05-04 11:32:23 -04:00
Caleb Ukle
3307188975
chore(repo): always log error for runCommandUntil (#16748) 2023-05-04 13:31:15 +03:00
Jason Jean
a0d18bb588
chore(repo): replace references to @nrwl in e2e tests (#16441) 2023-04-24 18:48:44 -04:00
Miroslav Jonaš
8519fbc7a6
fix(repo): fix mismatched package manager e2e utils (#16502) 2023-04-24 17:47:14 +02:00
Jason Jean
7bef2a6161
chore(core): fix e2e tests for yarn + workspace-create-npm (#16451) 2023-04-21 11:15:10 +03:00
Jason Jean
2d195007b0
feat(core): switch packages to use the @nx scope (#16069) 2023-04-14 19:56:37 -04:00
Jason Jean
afcf7ba19f
feat(core): remove usage of --legacy-peer-deps (#16271) 2023-04-12 16:31:46 -04:00
Miroslav Jonaš
b3a3f2a724
fix(core): ensurePackage fails on pnpm workspaces (#16002) 2023-04-06 10:47:15 -04:00
Miroslav Jonaš
cb5a7d8d35
fix(repo): use lerna command in e2e with yarn --silent (#16155) 2023-04-06 13:51:50 +02:00
Jack Hsu
2f87661ea2
chore(repo): use --silent when running through yarn to avoid unexpected strings (#16089) 2023-04-04 13:16:52 -04:00
Craigory Coppola
7d61ae238b
fix(misc): prevent --quiet and --verbose from both being true (#15836) 2023-03-23 10:47:43 -04:00
Miroslav Jonaš
c6904619aa
fix(angular): fix e2e tests to support pnpm v7 (#15587) 2023-03-16 12:22:22 +01:00
Miroslav Jonaš
7450e724b7
feat(repo): add new flag for verbose e2e logging (#15541) 2023-03-13 17:30:21 +00:00
Katerina Skroumpelou
a0e00c85fc
fix(core): refactor the logging logic in e2e tests (#15548) 2023-03-09 15:13:32 -05:00
Craigory Coppola
4a53ace70d
fix(core): nx migrate should work in encapsulated Nx repos (#15338) 2023-03-03 15:45:42 -05:00
Katerina Skroumpelou
808ca1215c
chore(core): rearrange e2e utils (#15421) 2023-03-03 15:22:23 +00:00