499300fd76
using `windowsHide: true` is causing an issue on windows: Ctrl + C handling isn't enabled and no `SIGINT` is sent to the child process when users exit the process. See https://github.com/nodejs/node/issues/29837 and https://github.com/nodejs/node-v0.x-archive/issues/5054 for reference. This will cause leftover processes throughout nx. This PR sets `windowsHide: false` everywhere except for the plugin workers and some short-lived utils. They `spawn` child processes but have explicit handling to make sure they kill themselves when the parent process dies, so the missing Ctrl + C handling doesn't cause issues. We will follow up to make sure any other culprits that still cause windows popups (especially when used through Nx Console) are handled. Leaving no leftover processes running is more important for now, though. Keep in mind the underlying tooling (like vite) might have some windows popups themselves that Nx will inherit.
84 lines
2.4 KiB
TypeScript
84 lines
2.4 KiB
TypeScript
import { type Plugin } from 'vite';
|
|
import { BatchFunctionRunner } from 'nx/src/command-line/watch/watch';
|
|
import { exec, type ChildProcess } from 'child_process';
|
|
import {
|
|
daemonClient,
|
|
type UnregisterCallback,
|
|
} from 'nx/src/daemon/client/client';
|
|
import { output } from 'nx/src/utils/output';
|
|
|
|
export interface NxViteBuildCoordinationPluginOptions {
|
|
buildCommand: string;
|
|
}
|
|
export function nxViteBuildCoordinationPlugin(
|
|
options: NxViteBuildCoordinationPluginOptions
|
|
): Plugin {
|
|
let activeBuildProcess: ChildProcess | undefined;
|
|
let unregisterFileWatcher: UnregisterCallback | undefined;
|
|
|
|
async function buildChangedProjects() {
|
|
await new Promise<void>((res) => {
|
|
activeBuildProcess = exec(options.buildCommand, {
|
|
windowsHide: false,
|
|
});
|
|
activeBuildProcess.stdout.pipe(process.stdout);
|
|
activeBuildProcess.stderr.pipe(process.stderr);
|
|
activeBuildProcess.on('exit', () => {
|
|
res();
|
|
});
|
|
activeBuildProcess.on('error', () => {
|
|
res();
|
|
});
|
|
});
|
|
activeBuildProcess = undefined;
|
|
}
|
|
|
|
function createFileWatcher() {
|
|
const runner = new BatchFunctionRunner(() => buildChangedProjects());
|
|
return daemonClient.registerFileWatcher(
|
|
{ watchProjects: 'all' },
|
|
(err, { changedProjects, changedFiles }) => {
|
|
if (err === 'closed') {
|
|
output.error({
|
|
title: 'Watch connection closed',
|
|
bodyLines: [
|
|
'The daemon had closed the connection to this watch process.',
|
|
'Please restart your watch command.',
|
|
],
|
|
});
|
|
process.exit(1);
|
|
}
|
|
|
|
if (activeBuildProcess) {
|
|
activeBuildProcess.kill(2);
|
|
activeBuildProcess = undefined;
|
|
}
|
|
|
|
runner.enqueue(changedProjects, changedFiles);
|
|
}
|
|
);
|
|
}
|
|
|
|
let firstBuildStart = true;
|
|
|
|
return {
|
|
name: 'nx-vite-build-coordination-plugin',
|
|
async buildStart() {
|
|
if (firstBuildStart) {
|
|
firstBuildStart = false;
|
|
await buildChangedProjects();
|
|
if (daemonClient.enabled()) {
|
|
unregisterFileWatcher = await createFileWatcher();
|
|
process.on('exit', () => unregisterFileWatcher());
|
|
process.on('SIGINT', () => process.exit());
|
|
} else {
|
|
output.warn({
|
|
title:
|
|
'Nx Daemon is not enabled. Projects will not be rebuilt when files change.',
|
|
});
|
|
}
|
|
}
|
|
},
|
|
};
|
|
}
|