Jack Hsu d39624cbb1
feat(js): @nx/js:init generator does not generate prettier and tsconfig.base.json files by default (#27406)
In order to use `nx release` you must run `nx add @nx/js`. However, the
init generator will add Prettier and `tsconfig.base.json` files by
default, which is not what the user wants.

This PR adds two options:
- `addTsConfigBase` - generates `tsconfig.base.json` when `true`.
Default to`false`
- `setUpPrettier` - adds `prettier` and generates `.prettierrc` and
`.prettierignore` files when `true`. Defaults to `false`.

The programmatic `initGenerator` API defaults both options to `true` to
usages remain unaffected.

The one behavior change is if users run `nx g @nx/js:init` then the two
options default to `false`. However, since this is an internal API, the
actual usages should be through `nx add` or the programmatic API.



<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
2024-08-14 09:08:56 -04:00

181 lines
4.7 KiB
TypeScript

import {
addDependenciesToPackageJson,
ensurePackage,
formatFiles,
generateFiles,
GeneratorCallback,
readJson,
stripIndents,
Tree,
updateJson,
writeJson,
} from '@nx/devkit';
import { checkAndCleanWithSemver } from '@nx/devkit/src/utils/semver';
import { readModulePackageJson } from 'nx/src/utils/package-json';
import { satisfies, valid } from 'semver';
import { getRootTsConfigFileName } from '../../utils/typescript/ts-config';
import {
nxVersion,
prettierVersion,
supportedTypescriptVersions,
swcCoreVersion,
swcHelpersVersion,
swcNodeVersion,
typescriptVersion,
} from '../../utils/versions';
import { InitSchema } from './schema';
import { join } from 'path';
async function getInstalledTypescriptVersion(
tree: Tree
): Promise<string | null> {
const rootPackageJson = readJson(tree, 'package.json');
const tsVersionInRootPackageJson =
rootPackageJson.devDependencies?.['typescript'] ??
rootPackageJson.dependencies?.['typescript'];
if (!tsVersionInRootPackageJson) {
return null;
}
if (valid(tsVersionInRootPackageJson)) {
// it's a pinned version, return it
return tsVersionInRootPackageJson;
}
// it's a version range, check whether the installed version matches it
try {
const tsPackageJson = readModulePackageJson('typescript').packageJson;
const installedTsVersion =
tsPackageJson.devDependencies?.['typescript'] ??
tsPackageJson.dependencies?.['typescript'];
// the installed version matches the package.json version range
if (
installedTsVersion &&
satisfies(installedTsVersion, tsVersionInRootPackageJson)
) {
return installedTsVersion;
}
} finally {
return checkAndCleanWithSemver('typescript', tsVersionInRootPackageJson);
}
}
export async function initGenerator(
tree: Tree,
schema: InitSchema
): Promise<GeneratorCallback> {
return initGeneratorInternal(tree, {
addTsConfigBase: true,
setUpPrettier: true,
...schema,
});
}
export async function initGeneratorInternal(
tree: Tree,
schema: InitSchema
): Promise<GeneratorCallback> {
const tasks: GeneratorCallback[] = [];
// add tsconfig.base.json
if (schema.addTsConfigBase && !getRootTsConfigFileName(tree)) {
generateFiles(tree, join(__dirname, './files'), '.', {
fileName: schema.tsConfigName ?? 'tsconfig.base.json',
});
}
const devDependencies = {
'@nx/js': nxVersion,
// When loading .ts config files (e.g. webpack.config.ts, jest.config.ts, etc.)
// we prefer to use SWC, and fallback to ts-node for workspaces that don't use SWC.
'@swc-node/register': swcNodeVersion,
'@swc/core': swcCoreVersion,
'@swc/helpers': swcHelpersVersion,
};
if (!schema.js && !schema.keepExistingVersions) {
const installedTsVersion = await getInstalledTypescriptVersion(tree);
if (
!installedTsVersion ||
!satisfies(installedTsVersion, supportedTypescriptVersions, {
includePrerelease: true,
})
) {
devDependencies['typescript'] = typescriptVersion;
}
}
if (schema.setUpPrettier) {
devDependencies['prettier'] = prettierVersion;
// https://prettier.io/docs/en/configuration.html
const prettierrcNameOptions = [
'.prettierrc',
'.prettierrc.json',
'.prettierrc.yml',
'.prettierrc.yaml',
'.prettierrc.json5',
'.prettierrc.js',
'.prettierrc.cjs',
'.prettierrc.mjs',
'.prettierrc.toml',
'prettier.config.js',
'prettier.config.cjs',
'prettier.config.mjs',
];
if (prettierrcNameOptions.every((name) => !tree.exists(name))) {
writeJson(tree, '.prettierrc', {
singleQuote: true,
});
}
if (!tree.exists(`.prettierignore`)) {
tree.write(
'.prettierignore',
stripIndents`
# Add files here to ignore them from prettier formatting
/dist
/coverage
/.nx/cache
/.nx/workspace-data
`
);
}
}
if (tree.exists('.vscode/extensions.json')) {
updateJson(tree, '.vscode/extensions.json', (json) => {
json.recommendations ??= [];
const extension = 'esbenp.prettier-vscode';
if (!json.recommendations.includes(extension)) {
json.recommendations.push(extension);
}
return json;
});
}
const installTask = !schema.skipPackageJson
? addDependenciesToPackageJson(
tree,
{},
devDependencies,
undefined,
schema.keepExistingVersions
)
: () => {};
tasks.push(installTask);
if (schema.setUpPrettier) {
ensurePackage('prettier', prettierVersion);
if (!schema.skipFormat) await formatFiles(tree);
}
return async () => {
for (const task of tasks) {
await task();
}
};
}
export default initGenerator;