cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix: do not filter report from functions within class elements (#13106)

Browse Source
This commit is contained in:
Huáng Jùnliàng 2021-04-05 16:02:02 -04:00 committed by GitHub
parent 61e866f6b8
commit 7bc72bb451
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 55 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
eslint/babel-eslint-plugin/src/rules/no-invalid-this.js
View File

@ -17,7 +17,13 @@ export default ruleComposer.filterReports(noInvalidThisRule, problem => {
node.key.type === "PrivateIdentifier")
) {
inClassMember = true;
return;
break;
} else if (
node.type === "FunctionDeclaration" ||
node.type === "FunctionExpression"
) {
inClassMember = false;
break;
}
node = node.parent;

48
eslint/babel-eslint-plugin/test/rules/no-invalid-this.js
View File

@ -93,6 +93,30 @@ const patterns = [
invalid: [],
},
{
code: "class A {a = () => { function b() { return this.b;} };};",
parserOptions: { ecmaVersion: 6 },
valid: [],
invalid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
errors: [
{
message: "Unexpected 'this'.",
},
],
},
{
code: "class A {a = () => { (function b() { return this.b;}); };};",
parserOptions: { ecmaVersion: 6 },
valid: [],
invalid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
errors: [
{
message: "Unexpected 'this'.",
},
],
},
// Class Private methods
{
code: "class A {#a = this.b;};",
@ -108,6 +132,30 @@ const patterns = [
invalid: [],
},
{
code: "class A {#a = () => { function b() { return this.b;} };};",
parserOptions: { ecmaVersion: 6 },
valid: [],
invalid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
errors: [
{
message: "Unexpected 'this'.",
},
],
},
{
code: "class A {#a = () => { (function b() { return this.b;}); };};",
parserOptions: { ecmaVersion: 6 },
valid: [],
invalid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
errors: [
{
message: "Unexpected 'this'.",
},
],
},
{
code: "class A {#a() {return this.b;};};",
parserOptions: { ecmaVersion: 6 },