fix: assure left bracket is not consumed after dot (#13695)

* fix: assure left bracket is not consumed after dot

* address review comments
This commit is contained in:
Huáng Jùnliàng 2021-08-20 05:29:44 -04:00 committed by GitHub
parent e0c3969a24
commit 976bfbbf69
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 5 deletions

View File

@ -701,6 +701,7 @@ export default class ExpressionParser extends LValParser {
}
let optional = false;
if (this.match(tt.questionDot)) {
if (noCalls && this.lookaheadCharCode() === charCodes.leftParenthesis) {
// stop at `?.` when parsing `new a?.()`
@ -719,11 +720,21 @@ export default class ExpressionParser extends LValParser {
state,
optional,
);
} else if (optional || this.match(tt.bracketL) || this.eat(tt.dot)) {
return this.parseMember(base, startPos, startLoc, state, optional);
} else {
state.stop = true;
return base;
const computed = this.eat(tt.bracketL);
if (computed || optional || this.eat(tt.dot)) {
return this.parseMember(
base,
startPos,
startLoc,
state,
computed,
optional,
);
} else {
state.stop = true;
return base;
}
}
}
@ -736,10 +747,10 @@ export default class ExpressionParser extends LValParser {
startPos: number,
startLoc: Position,
state: N.ParseSubscriptState,
computed: boolean,
optional: boolean,
): N.OptionalMemberExpression | N.MemberExpression {
const node = this.startNodeAt(startPos, startLoc);
const computed = this.eat(tt.bracketL);
node.object = base;
node.computed = computed;
const privateName =

View File

@ -0,0 +1,3 @@
{
"throws": "Unexpected token (1:2)"
}