miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(misc): handle external nodes correctly in module federation additional shared config (#11018)

Browse Source
This commit is contained in:
Leosvel Pérez Espinosa 2022-07-05 14:21:19 +01:00 committed by GitHub
parent e2ddb63aa1
commit 23d94a82d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/angular/src/utils/mf/with-module-federation.ts
View File

@ -180,7 +180,7 @@ function addStringDependencyToSharedConfig(
): void { ): void {
if (projectGraph.nodes[dependency]) { if (projectGraph.nodes[dependency]) {
sharedConfig[dependency] = { requiredVersion: false }; sharedConfig[dependency] = { requiredVersion: false };
} else if (projectGraph.externalNodes?.[dependency]) { } else if (projectGraph.externalNodes?.[`npm:${dependency}`]) {
const pkgJson = readRootPackageJson(); const pkgJson = readRootPackageJson();
const config = getNpmPackageSharedConfig( const config = getNpmPackageSharedConfig(
dependency, dependency,

2
packages/react/src/module-federation/with-module-federation.ts
View File

@ -170,7 +170,7 @@ function addStringDependencyToSharedConfig(
): void { ): void {
if (projectGraph.nodes[dependency]) { if (projectGraph.nodes[dependency]) {
sharedConfig[dependency] = { requiredVersion: false }; sharedConfig[dependency] = { requiredVersion: false };
} else if (projectGraph.externalNodes?.[dependency]) { } else if (projectGraph.externalNodes?.[`npm:${dependency}`]) {
const pkgJson = readRootPackageJson(); const pkgJson = readRootPackageJson();
const config = getNpmPackageSharedConfig( const config = getNpmPackageSharedConfig(
dependency, dependency,