miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(cra-to-nx): use cross-env to ensure Windows compatibility with CRA build script (#12838)

Browse Source
This commit is contained in:
Mérill Téterel 2022-10-28 17:23:48 +02:00 committed by GitHub
parent e39cb42c86
commit 48c6024fd5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/cra-to-nx/src/lib/add-cra-commands-to-nx.ts
View File

@ -6,7 +6,7 @@ export function addCRAcracoScriptsToPackageJson(appName: string) {
...packageJson.scripts, ...packageJson.scripts,
start: 'craco start', start: 'craco start',
serve: 'npm start', serve: 'npm start',
build: `BUILD_PATH=../../dist/apps/${appName} craco build`, build: `cross-env BUILD_PATH=../../dist/apps/${appName} craco build`,
test: 'craco test', test: 'craco test',
}; };
writeJsonSync(`apps/${appName}/package.json`, packageJson, { spaces: 2 }); writeJsonSync(`apps/${appName}/package.json`, packageJson, { spaces: 2 });

1
packages/cra-to-nx/src/lib/cra-to-nx.ts
View File

@ -165,6 +165,7 @@ export async function createNxWorkspaceForReact(options: Record<string, any>) {
addDependency('@craco/craco', true); addDependency('@craco/craco', true);
addDependency('web-vitals', true); addDependency('web-vitals', true);
addDependency('jest-watch-typeahead', true); // Only for ts apps? addDependency('jest-watch-typeahead', true); // Only for ts apps?
addDependency('cross-env', true);
output.log({ output.log({
title: '🎉 Done!', title: '🎉 Done!',