miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

fix(storybook): remove webpack v4 typings (#5638)

Browse Source 
there are different version potentially installed
This commit is contained in:
Juri Strumpflohner 2021-05-12 21:59:05 +02:00 committed by GitHub
parent fb197a27a9
commit a75143caff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/storybook/src/generators/init/init.spec.ts
View File

@ -35,7 +35,6 @@ describe('@nrwl/storybook:init', () => {
expect( expect(
packageJson.devDependencies['@storybook/addon-knobs'] packageJson.devDependencies['@storybook/addon-knobs']
).toBeDefined(); ).toBeDefined();
expect(packageJson.devDependencies['@types/webpack']).toBeDefined();
// angular specific // angular specific
expect(packageJson.devDependencies['@storybook/angular']).toBeDefined(); expect(packageJson.devDependencies['@storybook/angular']).toBeDefined();

2
packages/storybook/src/generators/init/init.ts
View File

@ -15,7 +15,6 @@ import {
storybookVersion, storybookVersion,
svgrVersion, svgrVersion,
urlLoaderVersion, urlLoaderVersion,
webpackTypesVersion,
} from '../../utils/versions'; } from '../../utils/versions';
import { isFramework } from '../../utils/utilities'; import { isFramework } from '../../utils/utilities';
import { Schema } from './schema'; import { Schema } from './schema';
@ -29,7 +28,6 @@ function checkDependenciesInstalled(host: Tree, schema: Schema) {
// base deps // base deps
devDependencies['@nrwl/storybook'] = nxVersion; devDependencies['@nrwl/storybook'] = nxVersion;
devDependencies['@types/webpack'] = webpackTypesVersion;
/** /**
* If Storybook already exists, do NOT update it to the latest version. * If Storybook already exists, do NOT update it to the latest version.

1
packages/storybook/src/utils/versions.ts
View File

@ -3,6 +3,5 @@ export const storybookVersion = '^6.1.11';
export const babelCoreVersion = '7.12.13'; export const babelCoreVersion = '7.12.13';
export const babelLoaderVersion = '8.1.0'; export const babelLoaderVersion = '8.1.0';
export const babelPresetTypescriptVersion = '7.12.13'; export const babelPresetTypescriptVersion = '7.12.13';
export const webpackTypesVersion = '4.41.21';
export const svgrVersion = '^5.4.0'; export const svgrVersion = '^5.4.0';
export const urlLoaderVersion = '^3.0.0'; export const urlLoaderVersion = '^3.0.0';